[Azure] convert gfx::2d from NULL to nullptr

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nrc, Assigned: Joe Drew (not getting mail))

Tracking

15 Branch
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 651830 [details] [diff] [review]
do it
Assignee: ncameron → joe
Attachment #651830 - Flags: review?(bas.schouten)
Comment on attachment 651830 [details] [diff] [review]
do it

Review of attachment 651830 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/gfx2d.vcxproj
@@ +117,5 @@
>    </ItemGroup>
>    <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
>    <ImportGroup Label="ExtensionTargets">
>    </ImportGroup>
> +</Project>

Not sure we need this change :) Saving the project in MSVC again might overwrite it!
Attachment #651830 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d2c24ce932
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla17
(Assignee)

Comment 4

5 years ago
backed out because I am a moron who doesn't know how to test his code 
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce9bc206a7d
Target Milestone: mozilla17 → ---
(Assignee)

Comment 5

5 years ago
Created attachment 652174 [details] [diff] [review]
put nullptr somewhere that works

Turns out that a bunch of 2d didn't support nullptr with only the previous patch. This patch fixes that.
Attachment #652174 - Flags: review?(ncameron)
(Reporter)

Comment 6

5 years ago
Comment on attachment 652174 [details] [diff] [review]
put nullptr somewhere that works

Review of attachment 652174 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: gfx/2d/2D.h
@@ +5,5 @@
>  
>  #ifndef _MOZILLA_GFX_2D_H
>  #define _MOZILLA_GFX_2D_H
>  
> +#include "Types.h"

I don't think you need this include, but if you _want_ it, then it is fine
Attachment #652174 - Flags: review?(ncameron) → review+
(Assignee)

Comment 7

5 years ago
I want it!
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e00f4d16eeed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f6b4e0bcef0
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla17

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e00f4d16eeed
https://hg.mozilla.org/mozilla-central/rev/8f6b4e0bcef0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.