Closed Bug 782432 Opened 12 years ago Closed 11 years ago

IonMonkey: Compile small functions more aggressively

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: djvj, Assigned: djvj)

Details

(Whiteboard: [ion:t])

Attachments

(1 file)

Current compile heuristics use Ion to compile a function after roughly 10K uses.

Intuition and experimentation indicates that compiling "small" functions more aggressively (i.e. with lower use count) is worthwhile.

Reasoning:
1. Small functions are likely to be called more often on average.
2. Even when they're not, their compile cost is low, so we don't lose much if we're wrong.

Implementation:
Compile small functions with a lower use count.
Assignee: general → kvijayan
Attached patch Patch.Splinter Review
Attachment #651547 - Flags: review?(dvander)
Attachment #651547 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/a8235a2a29c2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/projects/ionmonkey/rev/a258b96b94ea

Rolled back patch as it significantly regressed a few benches in 32-bit SS, namely, access-binary-tree, crypto-md5, and bitops-bits-in-byte.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Cleaning up old bugs that are defunct.
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: