78247 - History preferences accepts negative values

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Junk_HbJ]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.8.1+) Gecko/20010430
BuildID:    2001043004

The preferences for history allow negative values for the expiration of global
history entries as well as for the session history size.

Reproducible: Always
Steps to Reproduce:
1. Go to "Edit - Preferences"
2. Select "Pages in history expire after : x days"
3. Set x to -11
4. Select "Session history size : y days"
5. Set y to -11

Actual Results:  Negative values accepted and saved.

Expected Results:  Negative values rejected.

This bug is inspired by my findings in bug 78175

Comment 1

[Alec Flett]

wow, that's bad!

Comment 2

[Paul Chen]

nav triage team:

So NOT a beta stopper, marking nsbeta1- and mozilla1.0

Comment 3

[Alexander Zuev]

Attachment: Fix part 1

Comment 4

[Alexander Zuev]

Attachment: Fix part 2

Comment 5

[Alexander Zuev]

Proposed fix attached. Changing negative value to 9 (default) and notifying user
about it.

Comment 6

[Alec Flett]

Thanks for the work here! I hate to tell you this now, but I'm getting rid of
onHistoryOK - can you put this in the onblur handler of the text widget instead?
If you do that, I don't think an alert is necessary, not to mention we're in a
UI freeze, so we'd rather not have a new string added.

Comment 7

[Alexander Zuev]

Attachment: New fix.

Comment 8

[Alexander Zuev]

Ok, i did this change, but on current sources i can't change this preference at
all! After pressing OK button and reopening this preferences page preference
stays unchanged! Just filled bug about it. Bug 83473.

Comment 9

[Alec Flett]

now wasn't that easy? :)
sr=alecf

Comment 10

[Alec Flett]

that's not a dependancy though - it doesn't block you from fixing this
particular bug

Comment 11

[Paul Chen]

nav triage team:

Not super critical for mozilla1.0, pushing out to mozilla1.0.1

Comment 12

[shrirang khanzode]

well, the history pref also accepts characters in addition to numbers. Howevever
the characters are not seen when I reopen prefs history panel, I see '0'. Only
numbers and that too positive should be accepted :)

Comment 13

[Alec Flett]

reassigning history bugs to new owner - send this bug back to me if it looks
like something I should fix (such as embedding-related architecture issues),
rather than the actual history owner...

Comment 14

[Blake Ross]

bad values aren't saved anymore, we have other bugs on more immediate feedback.

Comment 15

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]

Comment 16

[Oleg Sidletskiy]

how is this fixed?, on windows 98 maybe. But I can easily reproduce it with
Windows XP...