Last Comment Bug 782485 - Turn nsXULPrototypeNode into a non-nsISupports, purple-buffered cycle collected class
: Turn nsXULPrototypeNode into a non-nsISupports, purple-buffered cycle collect...
Product: Core
Classification: Components
Component: XUL (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Andrew McCreight [:mccr8]
: Neil Deakin
Depends on: 750424 750570
  Show dependency treegraph
Reported: 2012-08-13 18:56 PDT by Andrew McCreight [:mccr8]
Modified: 2012-08-24 20:02 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

change it up (6.59 KB, patch)
2012-08-13 19:06 PDT, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-08-13 18:56:15 PDT
With bug 750570, we should be able to do this easily.
Comment 1 Andrew McCreight [:mccr8] 2012-08-13 19:06:00 PDT
Created attachment 651613 [details] [diff] [review]
change it up

One thing I've noticed while working on this is that it is really easy to make the declaration SCRIPT_HOLDER, but then forget it for the implementation, which isn't detected until runtime, via a null-deref in a weird place. I should probably improve that somehow...
Comment 2 Andrew McCreight [:mccr8] 2012-08-23 17:03:18 PDT
Comment on attachment 651613 [details] [diff] [review]
change it up

No big hurry on this or the other one, but we might as well do this at some point, once I get around to landing the native CC purple buffer stuff.
Comment 3 Andrew McCreight [:mccr8] 2012-08-24 09:52:02 PDT
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-24 20:02:05 PDT

Note You need to log in before you can comment on or make changes to this bug.