Closed Bug 782485 Opened 8 years ago Closed 8 years ago

Turn nsXULPrototypeNode into a non-nsISupports, purple-buffered cycle collected class

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

With bug 750570, we should be able to do this easily.
Attached patch change it upSplinter Review
One thing I've noticed while working on this is that it is really easy to make the declaration SCRIPT_HOLDER, but then forget it for the implementation, which isn't detected until runtime, via a null-deref in a weird place. I should probably improve that somehow...
Assignee: nobody → continuation
Depends on: 750424
Comment on attachment 651613 [details] [diff] [review]
change it up

No big hurry on this or the other one, but we might as well do this at some point, once I get around to landing the native CC purple buffer stuff.
Attachment #651613 - Flags: review?(bugs)
Attachment #651613 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c144761a799f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.