Turn nsXULPrototypeNode into a non-nsISupports, purple-buffered cycle collected class

RESOLVED FIXED in mozilla17

Status

()

Core
XUL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
With bug 750570, we should be able to do this easily.
(Assignee)

Comment 1

5 years ago
Created attachment 651613 [details] [diff] [review]
change it up

One thing I've noticed while working on this is that it is really easy to make the declaration SCRIPT_HOLDER, but then forget it for the implementation, which isn't detected until runtime, via a null-deref in a weird place. I should probably improve that somehow...
Assignee: nobody → continuation
(Assignee)

Updated

5 years ago
Depends on: 750424
(Assignee)

Comment 2

5 years ago
Comment on attachment 651613 [details] [diff] [review]
change it up

No big hurry on this or the other one, but we might as well do this at some point, once I get around to landing the native CC purple buffer stuff.
Attachment #651613 - Flags: review?(bugs)

Updated

5 years ago
Attachment #651613 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c144761a799f
https://hg.mozilla.org/mozilla-central/rev/c144761a799f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.