Use NS_FAILED instead of boolean test for mBroken/IsBroken()

RESOLVED FIXED in mozilla17

Status

()

Core
HTML: Parser
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 651694 [details] [diff] [review]
Patch

mBroken is an nsresult, and IsBroken() returns an nsresult.  Testing them as though they were booleans won't compile when nsresult is an enum class, even though it will work fine as long as you don't use success codes other than NS_OK.  So NS_FAILED/NS_SUCCEEDED need to be used here.
Attachment #651694 - Flags: review?(hsivonen)
Attachment #651694 - Flags: review?(hsivonen) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/572b72100118

Green try: https://tbpl.mozilla.org/?tree=Try&rev=da4047717ef7
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/572b72100118
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.