782606 - Use NS_FAILED instead of boolean test (dom/indexedDB/, dom/workers/)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Testing an nsresult as a boolean isn't correct use of nsresult -- there are success codes other than NS_OK.  (Although maybe there shouldn't be!)  This will no longer compile when nsresult is an enum class, because enum classes can't be implicitly converted to other types.

This shouldn't change behavior as long as nothing here uses success codes other than NS_OK.  I wasn't able to easily verify that was the case here, but it seems likely.

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11d577df701f

Green try: https://tbpl.mozilla.org/?tree=Try&rev=da4047717ef7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11d577df701f