782614 - Fix still more abuse of nsresult (rdf/, xpcom/)

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Don't return nsresult from main() (rdf/)

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Don't return nsresult from main() (xpcom/)

Comment 3

[Benjamin Smedberg]

Comment on attachment 651724 [details] [diff] [review]
Don't return nsresult from main() (xpcom/)

In the very last hunk, please just return "2" instead of returning NS_ERROR_FAILURE as main() return code. r=me with that change.

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Green try except for Windows: https://tbpl.mozilla.org/?tree=Try&rev=fc3eb12e62f4  Windows isn't included because I'm trying to fix Windows build errors in other patches in the series, but it shouldn't behave any differently on Windows.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4210bdcf836
https://hg.mozilla.org/integration/mozilla-inbound/rev/84bf19883685

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> In the very last hunk, please just return "2" instead of returning
> NS_ERROR_FAILURE as main() return code. r=me with that change.

Oops, that was a mistake.  Thanks for catching it!

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e4210bdcf836
https://hg.mozilla.org/mozilla-central/rev/84bf19883685