The default bug view has changed. See this FAQ.

Fix still more abuse of nsresult (rdf/, xpcom/)

RESOLVED FIXED in mozilla17

Status

()

Core
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
Created attachment 651723 [details] [diff] [review]
Don't return nsresult from main() (rdf/)
Attachment #651723 - Flags: review?(benjamin)
Created attachment 651724 [details] [diff] [review]
Don't return nsresult from main() (xpcom/)
Attachment #651724 - Flags: review?(benjamin)
Summary: Fix still more abuse of nsresult (rdf/, xpcom/, toolkit/components/places/) → Fix still more abuse of nsresult (rdf/, xpcom/)
Attachment #651723 - Flags: review?(benjamin) → review+
Comment on attachment 651724 [details] [diff] [review]
Don't return nsresult from main() (xpcom/)

In the very last hunk, please just return "2" instead of returning NS_ERROR_FAILURE as main() return code. r=me with that change.
Attachment #651724 - Flags: review?(benjamin) → review+
Green try except for Windows: https://tbpl.mozilla.org/?tree=Try&rev=fc3eb12e62f4  Windows isn't included because I'm trying to fix Windows build errors in other patches in the series, but it shouldn't behave any differently on Windows.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4210bdcf836
https://hg.mozilla.org/integration/mozilla-inbound/rev/84bf19883685

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #3)
> In the very last hunk, please just return "2" instead of returning
> NS_ERROR_FAILURE as main() return code. r=me with that change.

Oops, that was a mistake.  Thanks for catching it!
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/e4210bdcf836
https://hg.mozilla.org/mozilla-central/rev/84bf19883685
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.