Closed
Bug 782651
Opened 12 years ago
Closed 12 years ago
Get importTestsuite.py working again
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files, 1 obsolete file)
3.41 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
50.39 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
I'd like to get this landed before gps turns everything around again...
Attachment #657643 -
Flags: review?(jhammel)
Assignee | ||
Comment 2•12 years ago
|
||
This puts the generated and generating code in sync
Attachment #657644 -
Flags: review?(jhammel)
Assignee | ||
Comment 3•12 years ago
|
||
Lost a few hunks somewhere
Attachment #657644 -
Attachment is obsolete: true
Attachment #657644 -
Flags: review?(jhammel)
Attachment #657645 -
Flags: review?(jhammel)
Comment 4•12 years ago
|
||
Comment on attachment 657643 [details] [diff] [review]
Part 1: Update writeMakefile to current best practices
lgtm
Attachment #657643 -
Flags: review?(jhammel) → review+
Comment 5•12 years ago
|
||
Comment on attachment 657645 [details] [diff] [review]
Part 2: Regenerate the code (v2)
I didn't go over this with a fine-toothed comb, but it seems correct
Attachment #657645 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•