Get importTestsuite.py working again

RESOLVED FIXED in mozilla18

Status

Testing
Mochitest
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 657643 [details] [diff] [review]
Part 1: Update writeMakefile to current best practices

I'd like to get this landed before gps turns everything around again...
Attachment #657643 - Flags: review?(jhammel)
(Assignee)

Comment 2

5 years ago
Created attachment 657644 [details] [diff] [review]
Part 2: Regenerate the code

This puts the generated and generating code in sync
Attachment #657644 - Flags: review?(jhammel)
(Assignee)

Comment 3

5 years ago
Created attachment 657645 [details] [diff] [review]
Part 2: Regenerate the code (v2)

Lost a few hunks somewhere
Attachment #657644 - Attachment is obsolete: true
Attachment #657644 - Flags: review?(jhammel)
Attachment #657645 - Flags: review?(jhammel)

Comment 4

5 years ago
Comment on attachment 657643 [details] [diff] [review]
Part 1: Update writeMakefile to current best practices

lgtm
Attachment #657643 - Flags: review?(jhammel) → review+

Comment 5

5 years ago
Comment on attachment 657645 [details] [diff] [review]
Part 2: Regenerate the code (v2)

I didn't go over this with a fine-toothed comb, but it seems correct
Attachment #657645 - Flags: review?(jhammel) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eaddbfdee40b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.