Closed Bug 782655 Opened 8 years ago Closed 8 years ago

Enable remote xul for b2g reftests

Categories

(Testing :: Reftest, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file, 1 obsolete file)

Reftests requiring remote xul timeout, e.g reftest-sanity/test-async.xul

See: http://i.imgur.com/pycKx.png
Attachment #652142 - Flags: review?(jgriffin)
Comment on attachment 652142 [details] [diff] [review]
Patch 1.0 - Enable remote xul in reftests

Review of attachment 652142 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

::: build/mobile/b2gautomation.py
@@ +256,5 @@
>          # run the script that starts the tests
>          elif hasattr(self, 'testScript'):
> +            args = None
> +            if hasattr(self, 'testScriptArgs'):
> +                args = self.testScriptArgs

It seems like it would be cleaner to set self.testScriptArgs = None in __init__; then you wouldn't need this slightly awkward pattern.
Attachment #652142 - Flags: review?(jgriffin) → review+
Thanks! Could you push on my behalf?
Attachment #652142 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b25f5ebc955
Assignee: nobody → ahalberstadt
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/7b25f5ebc955
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.