Closed
Bug 782655
Opened 13 years ago
Closed 13 years ago
Enable remote xul for b2g reftests
Categories
(Testing :: Reftest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.62 KB,
patch
|
Details | Diff | Splinter Review |
Reftests requiring remote xul timeout, e.g reftest-sanity/test-async.xul
See: http://i.imgur.com/pycKx.png
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #652142 -
Flags: review?(jgriffin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 652142 [details] [diff] [review]
Patch 1.0 - Enable remote xul in reftests
Review of attachment 652142 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
::: build/mobile/b2gautomation.py
@@ +256,5 @@
> # run the script that starts the tests
> elif hasattr(self, 'testScript'):
> + args = None
> + if hasattr(self, 'testScriptArgs'):
> + args = self.testScriptArgs
It seems like it would be cleaner to set self.testScriptArgs = None in __init__; then you wouldn't need this slightly awkward pattern.
Attachment #652142 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks! Could you push on my behalf?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #652142 -
Attachment is obsolete: true
|
|
||
Comment 4•13 years ago
|
||
Assignee: nobody → ahalberstadt
Target Milestone: --- → mozilla17
|
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•