Closed Bug 782707 Opened 8 years ago Closed 8 years ago

LoadObject(aForceLoad = true) prints bogus assertion if mType == eType_Loading ("Trying to load new plugin with existing content")

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: johns, Assigned: johns)

References

Details

Attachments

(2 files)

If you call LoadObject with aForceLoad while the type is "loading", we assert. We actually just need to return early if we're still in a valid loading state after UpdateObjectParameters()
If mType == eType_Loading we're waiting on a channel, but if mChannel already exists, we have nothing to do, so take an early return
Attachment #651833 - Flags: review?(joshmoz)
Attachment #651833 - Flags: review?(joshmoz) → review+
Arrgh, actually, this check should be lower, so we will close the channel immediately if state changed -- otherwise we'll wait for the channel to finish opening, and only then re-open it.
Attachment #652173 - Flags: review?(joshmoz)
Whiteboard: [leave open]
Attachment #652173 - Flags: review?(joshmoz) → review+
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/9d10b718c9a8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.