Last Comment Bug 782707 - LoadObject(aForceLoad = true) prints bogus assertion if mType == eType_Loading ("Trying to load new plugin with existing content")
: LoadObject(aForceLoad = true) prints bogus assertion if mType == eType_Loadin...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: John Schoenick [:johns]
:
Mentors:
Depends on:
Blocks: 745030
  Show dependency treegraph
 
Reported: 2012-08-14 10:53 PDT by John Schoenick [:johns]
Modified: 2012-08-17 19:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Avoid an assertion in nsObjectLoadingContent (1.06 KB, patch)
2012-08-14 11:06 PDT, John Schoenick [:johns]
jaas: review+
john: checkin+
Details | Diff | Review
Move waiting-on-channel bailout to after we potentially close it (2.53 KB, patch)
2012-08-15 12:19 PDT, John Schoenick [:johns]
jaas: review+
john: checkin+
Details | Diff | Review

Description John Schoenick [:johns] 2012-08-14 10:53:18 PDT
If you call LoadObject with aForceLoad while the type is "loading", we assert. We actually just need to return early if we're still in a valid loading state after UpdateObjectParameters()
Comment 1 John Schoenick [:johns] 2012-08-14 11:06:44 PDT
Created attachment 651833 [details] [diff] [review]
Avoid an assertion in nsObjectLoadingContent

If mType == eType_Loading we're waiting on a channel, but if mChannel already exists, we have nothing to do, so take an early return
Comment 2 John Schoenick [:johns] 2012-08-15 11:30:52 PDT
Comment on attachment 651833 [details] [diff] [review]
Avoid an assertion in nsObjectLoadingContent

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5418205a35f

try run:
https://tbpl.mozilla.org/?tree=Try&rev=1e72e421e6b8
Comment 3 John Schoenick [:johns] 2012-08-15 12:19:36 PDT
Created attachment 652173 [details] [diff] [review]
Move waiting-on-channel bailout to after we potentially close it

Arrgh, actually, this check should be lower, so we will close the channel immediately if state changed -- otherwise we'll wait for the channel to finish opening, and only then re-open it.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-15 18:44:43 PDT
https://hg.mozilla.org/mozilla-central/rev/a5418205a35f
Comment 5 John Schoenick [:johns] 2012-08-17 14:28:14 PDT
Comment on attachment 652173 [details] [diff] [review]
Move waiting-on-channel bailout to after we potentially close it

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d10b718c9a8

try:
https://tbpl.mozilla.org/?tree=Try&rev=46b32a4de584
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-17 19:21:57 PDT
https://hg.mozilla.org/mozilla-central/rev/9d10b718c9a8

Note You need to log in before you can comment on or make changes to this bug.