Closed Bug 782707 Opened 8 years ago Closed 8 years ago
Object(a Force Load = true) prints bogus assertion if m Type == e Type _Loading ("Trying to load new plugin with existing content")
If you call LoadObject with aForceLoad while the type is "loading", we assert. We actually just need to return early if we're still in a valid loading state after UpdateObjectParameters()
If mType == eType_Loading we're waiting on a channel, but if mChannel already exists, we have nothing to do, so take an early return
Attachment #651833 - Flags: review?(joshmoz)
Comment on attachment 651833 [details] [diff] [review] Avoid an assertion in nsObjectLoadingContent https://hg.mozilla.org/integration/mozilla-inbound/rev/a5418205a35f try run: https://tbpl.mozilla.org/?tree=Try&rev=1e72e421e6b8
Attachment #651833 - Flags: checkin+
Arrgh, actually, this check should be lower, so we will close the channel immediately if state changed -- otherwise we'll wait for the channel to finish opening, and only then re-open it.
Attachment #652173 - Flags: review?(joshmoz)
Comment on attachment 652173 [details] [diff] [review] Move waiting-on-channel bailout to after we potentially close it https://hg.mozilla.org/integration/mozilla-inbound/rev/9d10b718c9a8 try: https://tbpl.mozilla.org/?tree=Try&rev=46b32a4de584
Attachment #652173 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.