LoadObject(aForceLoad = true) prints bogus assertion if mType == eType_Loading ("Trying to load new plugin with existing content")

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: johns, Assigned: johns)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
If you call LoadObject with aForceLoad while the type is "loading", we assert. We actually just need to return early if we're still in a valid loading state after UpdateObjectParameters()
(Assignee)

Comment 1

5 years ago
Created attachment 651833 [details] [diff] [review]
Avoid an assertion in nsObjectLoadingContent

If mType == eType_Loading we're waiting on a channel, but if mChannel already exists, we have nothing to do, so take an early return
Attachment #651833 - Flags: review?(joshmoz)

Updated

5 years ago
Attachment #651833 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 651833 [details] [diff] [review]
Avoid an assertion in nsObjectLoadingContent

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5418205a35f

try run:
https://tbpl.mozilla.org/?tree=Try&rev=1e72e421e6b8
Attachment #651833 - Flags: checkin+
(Assignee)

Comment 3

5 years ago
Created attachment 652173 [details] [diff] [review]
Move waiting-on-channel bailout to after we potentially close it

Arrgh, actually, this check should be lower, so we will close the channel immediately if state changed -- otherwise we'll wait for the channel to finish opening, and only then re-open it.
Attachment #652173 - Flags: review?(joshmoz)
(Assignee)

Updated

5 years ago
Whiteboard: [leave open]

Updated

5 years ago
Attachment #652173 - Flags: review?(joshmoz) → review+
https://hg.mozilla.org/mozilla-central/rev/a5418205a35f
(Assignee)

Comment 5

5 years ago
Comment on attachment 652173 [details] [diff] [review]
Move waiting-on-channel bailout to after we potentially close it

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d10b718c9a8

try:
https://tbpl.mozilla.org/?tree=Try&rev=46b32a4de584
Attachment #652173 - Flags: checkin+
(Assignee)

Updated

5 years ago
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/9d10b718c9a8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.