Last Comment Bug 782772 - Support the href property in web activities
: Support the href property in web activities
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Other Branch
: x86_64 Linux
: -- normal (vote)
: mozilla17
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-14 13:53 PDT by [:fabrice] Fabrice Desré
Modified: 2013-04-04 13:52 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.46 KB, patch)
2012-08-14 13:53 PDT, [:fabrice] Fabrice Desré
no flags Details | Diff | Review
Patch, V2 (9.52 KB, patch)
2012-08-14 20:10 PDT, Gene Lian [:gene] (I already quit Mozilla)
21: review+
fabrice: review+
Details | Diff | Review

Description [:fabrice] Fabrice Desré 2012-08-14 13:53:47 PDT
Created attachment 651873 [details] [diff] [review]
patch

Currently we don't filter based on the pageURI in the system messages dispatcher, so we end up firing too many messages.

Gene, can you check the changes I had to make in the Alarm API?
Comment 1 Gene Lian [:gene] (I already quit Mozilla) 2012-08-14 19:06:51 PDT
(In reply to Fabrice Desré [:fabrice] from comment #0)
> Created attachment 651873 [details] [diff] [review]
> patch
> 
> Currently we don't filter based on the pageURI in the system messages
> dispatcher, so we end up firing too many messages.
> 
> Gene, can you check the changes I had to make in the Alarm API?

My pleasure :) After looking through the changes, I think we should also save the pageURI into the alarm database so that it can know where to send at next reboot. I can upload a new patch later by following your changes. Just give me 1 hour to have this done and test if everything works.
Comment 2 Gene Lian [:gene] (I already quit Mozilla) 2012-08-14 20:10:29 PDT
Created attachment 651982 [details] [diff] [review]
Patch, V2

Just following Fabrice's original patch to have a new one, which covers the alarm database for pageURL. After some testings, everything works well.
Comment 3 [:fabrice] Fabrice Desré 2012-08-14 21:12:00 PDT
Comment on attachment 651982 [details] [diff] [review]
Patch, V2

Review of attachment 651982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gene!
Comment 4 [:fabrice] Fabrice Desré 2012-08-15 09:32:26 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e73b7902658
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-15 18:45:44 PDT
https://hg.mozilla.org/mozilla-central/rev/5e73b7902658

Note You need to log in before you can comment on or make changes to this bug.