782772 - Support the href property in web activities

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[:fabrice] Fabrice Desré]

Attachment: patch

Currently we don't filter based on the pageURI in the system messages dispatcher, so we end up firing too many messages.

Gene, can you check the changes I had to make in the Alarm API?

Comment 1

[Gene Lian (I already quit Mozilla)]

(In reply to Fabrice Desré [:fabrice] from comment #0)
> Created attachment 651873 [details] [diff] [review]
> patch
> 
> Currently we don't filter based on the pageURI in the system messages
> dispatcher, so we end up firing too many messages.
> 
> Gene, can you check the changes I had to make in the Alarm API?

My pleasure :) After looking through the changes, I think we should also save the pageURI into the alarm database so that it can know where to send at next reboot. I can upload a new patch later by following your changes. Just give me 1 hour to have this done and test if everything works.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2

Just following Fabrice's original patch to have a new one, which covers the alarm database for pageURL. After some testings, everything works well.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 651982 [details] [diff] [review]
Patch, V2

Review of attachment 651982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gene!

Comment 4

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e73b7902658

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e73b7902658