The default bug view has changed. See this FAQ.

Support the href property in web activities

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: fabrice, Unassigned)

Tracking

Other Branch
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 651873 [details] [diff] [review]
patch

Currently we don't filter based on the pageURI in the system messages dispatcher, so we end up firing too many messages.

Gene, can you check the changes I had to make in the Alarm API?
Attachment #651873 - Flags: review?(clian)
Attachment #651873 - Flags: review?(21)
(In reply to Fabrice Desré [:fabrice] from comment #0)
> Created attachment 651873 [details] [diff] [review]
> patch
> 
> Currently we don't filter based on the pageURI in the system messages
> dispatcher, so we end up firing too many messages.
> 
> Gene, can you check the changes I had to make in the Alarm API?

My pleasure :) After looking through the changes, I think we should also save the pageURI into the alarm database so that it can know where to send at next reboot. I can upload a new patch later by following your changes. Just give me 1 hour to have this done and test if everything works.
Created attachment 651982 [details] [diff] [review]
Patch, V2

Just following Fabrice's original patch to have a new one, which covers the alarm database for pageURL. After some testings, everything works well.
Attachment #651873 - Attachment is obsolete: true
Attachment #651873 - Flags: review?(clian)
Attachment #651873 - Flags: review?(21)
Attachment #651982 - Flags: review?(fabrice)
Attachment #651982 - Flags: review?(21)
(Reporter)

Comment 3

5 years ago
Comment on attachment 651982 [details] [diff] [review]
Patch, V2

Review of attachment 651982 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gene!
Attachment #651982 - Flags: review?(fabrice) → review+
Attachment #651982 - Flags: review?(21) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e73b7902658
https://hg.mozilla.org/mozilla-central/rev/5e73b7902658
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Updated

4 years ago
Component: DOM: Other → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.