Closed Bug 78280 Opened 25 years ago Closed 25 years ago

Search UI: File/Del operates on wrong msgs if resort with selection in place

Categories

(SeaMonkey :: MailNews: Message Display, defect, P1)

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: laurel, Assigned: naving)

References

Details

(Whiteboard: [nsbeta1+]Have Fix)

Attachments

(1 file)

Using apr30 commercial trunk build: win98, mac OS 9.0 and linux rh6.2 If you have a single or multiple selection in place in the search results pane and resort the list, if you then use Delete or File/Move on that selection the search results pane will show the wrong message deleted/moved. In most of the cases I've tried, the actual move or delete was indeed performed on the wrong/unintended message selection. In some cases it behaved against no rule; the operation was not performed at all on any message or was performed on the correct message, even though the search results did not match what was really done. This appears to be the same whether the search is done across folders or within one folder and happens with single or multiple selections in the search results. Can make the user have a panic attack, especially since the operations from search may or may not be able to be undone. Steps: 1. Login to a mail account (either IMAP or POP), select a populated mail folder. 2. Search|Search Mail/News Messages and initiate a search which will yield multiple results. 3. Select the last couple messages in the results pane. 4. Resort the list by clicking on a column, for instance to resort by date from ascending to descending click the date column to toggle. When resorted, the selected messages appear in a different place within the search results list. For instance, date toggle may place them at the top as opposed to the bottom where they first were. 5. The selection is still maintained, same couple messages are highlighted. Use the search UI File button to move them to another folder on the same account. 6. Search results display loses a couple messages, but the selected ones (the ones you intended to move) are still shown in the search ui results pane. 7. Check the folder you specified as the move destination -- it will likely have received the wrong messages from the search results File operation.
So, in other words, the search ui applies the file or delete operation to the message(s) which occupy the place(s) in the list when selection was originally made.
Keywords: nsbeta1
QA Contact: esther → laurel
Would this be reliant on work being done on bug 10872 (remember last selected message)?
that sounds bad. reassigning to naving.
Assignee: gayatrib → naving
Priority: -- → P1
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
Attached patch proposed fix — — Splinter Review
The reason it was broken was because m_hdrs was not being built after sorting. No need for m_hdrs because we already have m_keys and can fetch the hdrs. m_keys and m_folders are rebuilt on a sort operation.
Whiteboard: [nsbeta1+] → [nsbeta1+]Have Fix
Blocks: 77232
good, yes, sr=bienvenu
need r gayatri
r=gayatrib
fix checked in.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
OK using may09 commercial trunk build: win98, mac OS 9.0 OK using may08 commercial trunk build: linux rh6.2 Working ok for basic scenarios tried in del, file. Any further problems will be logged as separate issues.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: