The default bug view has changed. See this FAQ.

typos in gclicommands.properties

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Console
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aryx, Assigned: John Engler)

Tracking

18 Branch
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

Replace "it's" with "its":

cookieSetManual=Set a cookie by specifying a key name, it's value and optionally one or more of the following attributes: expires (max-age in seconds or the expires date in GMTString format), path, domain, secure

The following two descriptions should contain a "that", but I could be wrong (it sounds wrong to a non-native speaker like me):

# LOCALIZATION NOTE (addonAlreadyEnabled) Used in the output of the
# 'addon enable' command when an attempt is made to enable an addon is already
# enabled.

# LOCALIZATION NOTE (addonAlreadyDisabled) Used in the output of the
# 'addon disable' command when an attempt is made to disable an addon is already
# disabled.
(Assignee)

Comment 1

5 years ago
Hi,
  If this is not already assigned, I will happily take it as my first submit.

Comment 2

5 years ago
> If this is not already assigned, I will happily take it as my first submit.
Sure.
Assignee: nobody → jfengler4
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 652342 [details] [diff] [review]
Changes made as suggested.
Attachment #652342 - Flags: review?(jwalker)
(Assignee)

Comment 4

5 years ago
Also, I noticed that there are other inconsistencies within the gclicommands.properties file. Should I fix them and re-submit a patch under this bug or create a new bug?
You can also fix these issues in this bug.
(Assignee)

Comment 6

5 years ago
Thanks. Are there official guidelines one how the gclicommands should be structured? For example, when to use a period at the end of a sentence, etc?

Also, when referencing the document object, should it be capitalized? inspectNodeManual uses "Document.querySelector" but the actual command would be "document.querySelector". 

(In reply to Archaeopteryx [:aryx] from comment #5)
> You can also fix these issues in this bug.
> Thanks. Are there official guidelines one how the gclicommands should be
> structured? For example, when to use a period at the end of a sentence, etc?
I leave the gclicommands to the Style Editor owner, period at the end usually mean "launches something which requires user input" (CCing l10n for linking the documentation)

> Also, when referencing the document object, should it be capitalized?
> inspectNodeManual uses "Document.querySelector" but the actual command would
> be "document.querySelector". 
Yes, this should be changed to prevent confusion for people not being familiar with |document|. You will need to update the entity name because the meaning changes and the localizations should pick this up.
(Assignee)

Comment 8

5 years ago
Created attachment 654097 [details] [diff] [review]
Further spelling/grammar corrections
Attachment #652342 - Attachment is obsolete: true
Attachment #654097 - Flags: review?(jwalker)
Attachment #652342 - Flags: review?(jwalker)
Pike: This is in devtools, should all entity names be changed because some locales don't translate devtools or is there any other possibility to port the changes to theses localizations?

Comment 10

5 years ago
Some of these are borderline, so I've poked at mxr a bit to see if they're a problem.

The beauty vs pretty is mostly solved in the translations, the Javascript vs JavaScript isn't. The Document shows up about as often as document does.

I think we shouldn't change the keys, and just post in .l10n about the fixes.
(Assignee)

Comment 11

5 years ago
Is there anything I can (or need to) do to help?

(In reply to Axel Hecht [:Pike] from comment #10)
> Some of these are borderline, so I've poked at mxr a bit to see if they're a
> problem.
> 
> The beauty vs pretty is mostly solved in the translations, the Javascript vs
> JavaScript isn't. The Document shows up about as often as document does.
> 
> I think we shouldn't change the keys, and just post in .l10n about the fixes.
Comment on attachment 654097 [details] [diff] [review]
Further spelling/grammar corrections

Review of attachment 654097 [details] [diff] [review]:
-----------------------------------------------------------------

Many thanks.
Attachment #654097 - Flags: review?(jwalker) → review+

Updated

5 years ago
Keywords: checkin-needed
https://tbpl.mozilla.org/?tree=Fx-Team&rev=bbd267f16fc7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]

Comment 14

5 years ago
https://hg.mozilla.org/mozilla-central/rev/76b7f323b8f3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Comment 15

5 years ago
(In reply to John Engler from comment #11)
> Is there anything I can (or need to) do to help?
> 

Send a post to mozilla.dev.l10n? Thanks.
(Assignee)

Comment 16

5 years ago
(In reply to Axel Hecht [:Pike] from comment #15)
> (In reply to John Engler from comment #11)
> > Is there anything I can (or need to) do to help?
> > 
> 
> Send a post to mozilla.dev.l10n? Thanks.

Post sent. Thank you for everyone's help. :)
Version: Trunk → 18 Branch
You need to log in before you can comment on or make changes to this bug.