Closed Bug 782823 Opened 12 years ago Closed 11 years ago

about:pages cause LoadFaviconTask.doInBackground() to throw MalformedURLException

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: cpeterson, Assigned: ckitching)

References

Details

STR:
1. Watch adb logcat
2. Load about:config


: The provided favicon URL is not valid
: java.net.MalformedURLException: Unknown protocol: about
: 	at java.net.URL.<init>(URL.java:184)
: 	at java.net.URL.<init>(URL.java:127)
: 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:319)
: 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:220)
: 	at android.os.AsyncTask$2.call(AsyncTask.java:287)
: 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
: 	at java.util.concurrent.FutureTask.run(FutureTask.java:137)
: 	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
: 	at java.lang.Thread.run(Thread.java:856)
Fixed by the Favicon caching overhaul in Bug 888326. about pages either provide their Favicon in the database (as about:home and friends does), or they don't get one at all (Which is I imagine the expected behaviour for about:config).

Cripe, I accidentially fixed a lot of bugs with that work..
Assignee: nobody → ckitching
Depends on: 888326
Slightly confused. about: pages are often just html pages. They can specify a favicon in their source like any web page. Do those still work (i.e. about:addons or about:downloads?)
(In reply to Wesley Johnston (:wesj) from comment #2)
> Slightly confused. about: pages are often just html pages. They can specify
> a favicon in their source like any web page. Do those still work (i.e.
> about:addons or about:downloads?)

My apologies, my previous comment makes what I've done sound less general than it actually is - of course if you specify in an about:page a favicon URL and the Favicon isn't in the database it'll be fetched in the usual way (Using GeckoJarReader or the network).
Although this is probably not something you should actually do.
Status: NEW → ASSIGNED
(In reply to Chris Kitching [:ckitching] from comment #3)
> (In reply to Wesley Johnston (:wesj) from comment #2)
> > Slightly confused. about: pages are often just html pages. They can specify
> > a favicon in their source like any web page. Do those still work (i.e.
> > about:addons or about:downloads?)
> 
> My apologies, my previous comment makes what I've done sound less general
> than it actually is - of course if you specify in an about:page a favicon
> URL and the Favicon isn't in the database it'll be fetched in the usual way
> (Using GeckoJarReader or the network).
> Although this is probably not something you should actually do.

Why not? Using a link tag seems like a sensible way for about: pages to specify a favicon. For example, error pages do this:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/netError.xhtml#27
(In reply to :Margaret Leibovic from comment #4)
> Why not? Using a link tag seems like a sensible way for about: pages to
> specify a favicon. For example, error pages do this:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> netError.xhtml#27

I was referring in particular to the case of fetching from the network - wouldn't be hugely sensible for about pages or error pages to download a Favicon from the internet. Local URLs like this are fine, of course. (Although things might run slightly more quickly if the Favicons for this sort of thing were in the database from the start - but adding that at this point will be sort of hard and won't really win us that much.)
Depends on: FaviconRevamp
No longer depends on: 888326
Fixed by Bug 914296.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.