782852 - full-screen-api.approval-required pref should affect nsDocument::mIsApprovedForFullscreen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

If the pref "full-screen-api.approval-required" is false, pointerlock doesn't work on desktop.

"full-screen-api.approval-required" determines whether chrome JS shows approval UI for fullscreen. When the user approves fullscreen via the approval UI, chrome sends the "fullscreen-approved" notification to gecko, and if we have a pending pointer lock request it is granted.

So if the pref "full-screen-api.approval-required" is true, we won't ever show the approval UI, so we won't ever send "fullscreen-approved", and so pending pointer lock requests are never granted.

We should initialize nsDocument::mIsApprovedForFullscreen to true if full-screen-api.approval-required is false, i.e. we should take the same path for pointer lock as we do when fullscreen has been already approved by the user.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

As described in comment #0, initialize nsDocument::mIsApprovedForFullscreen to true if the "full-screen-api.approval-required" pref is false, i.e. take the same path for pointer lock as we do when fullscreen has been already approved by the user.

Pointer lock works when the "full-screen-api.approval-required" pref is false with this patch.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9dbc925fde8

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e9dbc925fde8