Closed Bug 782871 Opened 8 years ago Closed 8 years ago

Move TreeContext and related things into the Parser module

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files, 2 obsolete files)

TreeContext can be moved into the Parser module, and the TreeContext module
can then be renamed.
This patch moves TreeContext, frontend::GenerateBlockId and StmtInfoTC out
of the |TreeContext| module into the |Parser| module.  This is good because
they're all things that are only needed by the Parser (i.e. not by the
ByteCodeEmitter).

This results in the removal of frontend/TreeContext.cpp and the addition of
frontend/Parser-inl.h.

I also removed some unnecessary #include statements.
Attachment #651977 - Flags: review?(jorendorff)
This patch renames the |TreeContext| module as |SharedContext|, which better
reflects its contents.
Attachment #651978 - Flags: review?(jorendorff)
BTW, this will totally bit-rot the patches in bug 770865, but they're already rotten so it's no great loss, and they'll end up being smaller as a result of the changes in this bug.  I'm happy to take over that bug.
I'd be very appreciative if this could land after bug 775323.
Updated for Luke's recent changes.
Attachment #652674 - Flags: review?(jorendorff)
Updated for Luke's recent changes.
Attachment #652675 - Flags: review?(jorendorff)
Attachment #651977 - Attachment is obsolete: true
Attachment #651977 - Flags: review?(jorendorff)
Attachment #651978 - Attachment is obsolete: true
Attachment #651978 - Flags: review?(jorendorff)
Attachment #652674 - Flags: review?(jorendorff) → review+
Attachment #652675 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/9971bdf03cbb
https://hg.mozilla.org/mozilla-central/rev/2127be51a12e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.