Closed
Bug 782871
Opened 13 years ago
Closed 12 years ago
Move TreeContext and related things into the Parser module
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(2 files, 2 obsolete files)
46.47 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
7.63 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
TreeContext can be moved into the Parser module, and the TreeContext module
can then be renamed.
![]() |
Assignee | |
Comment 1•13 years ago
|
||
This patch moves TreeContext, frontend::GenerateBlockId and StmtInfoTC out
of the |TreeContext| module into the |Parser| module. This is good because
they're all things that are only needed by the Parser (i.e. not by the
ByteCodeEmitter).
This results in the removal of frontend/TreeContext.cpp and the addition of
frontend/Parser-inl.h.
I also removed some unnecessary #include statements.
Attachment #651977 -
Flags: review?(jorendorff)
![]() |
Assignee | |
Comment 2•13 years ago
|
||
This patch renames the |TreeContext| module as |SharedContext|, which better
reflects its contents.
Attachment #651978 -
Flags: review?(jorendorff)
![]() |
Assignee | |
Comment 3•13 years ago
|
||
BTW, this will totally bit-rot the patches in bug 770865, but they're already rotten so it's no great loss, and they'll end up being smaller as a result of the changes in this bug. I'm happy to take over that bug.
![]() |
||
Comment 4•13 years ago
|
||
I'd be very appreciative if this could land after bug 775323.
![]() |
Assignee | |
Comment 5•13 years ago
|
||
Updated for Luke's recent changes.
Attachment #652674 -
Flags: review?(jorendorff)
![]() |
Assignee | |
Comment 6•13 years ago
|
||
Updated for Luke's recent changes.
Attachment #652675 -
Flags: review?(jorendorff)
![]() |
Assignee | |
Updated•13 years ago
|
Attachment #651977 -
Attachment is obsolete: true
Attachment #651977 -
Flags: review?(jorendorff)
![]() |
Assignee | |
Updated•13 years ago
|
Attachment #651978 -
Attachment is obsolete: true
Attachment #651978 -
Flags: review?(jorendorff)
Updated•12 years ago
|
Attachment #652674 -
Flags: review?(jorendorff) → review+
Updated•12 years ago
|
Attachment #652675 -
Flags: review?(jorendorff) → review+
![]() |
Assignee | |
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9971bdf03cbb
https://hg.mozilla.org/mozilla-central/rev/2127be51a12e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•