The default bug view has changed. See this FAQ.

Move TreeContext and related things into the Parser module

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
TreeContext can be moved into the Parser module, and the TreeContext module
can then be renamed.
(Assignee)

Comment 1

5 years ago
Created attachment 651977 [details] [diff] [review]
Move TreeContext and related things into the Parser module.

This patch moves TreeContext, frontend::GenerateBlockId and StmtInfoTC out
of the |TreeContext| module into the |Parser| module.  This is good because
they're all things that are only needed by the Parser (i.e. not by the
ByteCodeEmitter).

This results in the removal of frontend/TreeContext.cpp and the addition of
frontend/Parser-inl.h.

I also removed some unnecessary #include statements.
Attachment #651977 - Flags: review?(jorendorff)
(Assignee)

Comment 2

5 years ago
Created attachment 651978 [details] [diff] [review]
Rename the |TreeContext| module as |SharedContext|.

This patch renames the |TreeContext| module as |SharedContext|, which better
reflects its contents.
Attachment #651978 - Flags: review?(jorendorff)
(Assignee)

Comment 3

5 years ago
BTW, this will totally bit-rot the patches in bug 770865, but they're already rotten so it's no great loss, and they'll end up being smaller as a result of the changes in this bug.  I'm happy to take over that bug.

Comment 4

5 years ago
I'd be very appreciative if this could land after bug 775323.
(Assignee)

Comment 5

5 years ago
Created attachment 652674 [details] [diff] [review]
Move TreeContext and related things into the Parser module.

Updated for Luke's recent changes.
Attachment #652674 - Flags: review?(jorendorff)
(Assignee)

Comment 6

5 years ago
Created attachment 652675 [details] [diff] [review]
Rename the |TreeContext| module as |SharedContext|.

Updated for Luke's recent changes.
Attachment #652675 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Attachment #651977 - Attachment is obsolete: true
Attachment #651977 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Attachment #651978 - Attachment is obsolete: true
Attachment #651978 - Flags: review?(jorendorff)
Attachment #652674 - Flags: review?(jorendorff) → review+
Attachment #652675 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9971bdf03cbb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2127be51a12e
https://hg.mozilla.org/mozilla-central/rev/9971bdf03cbb
https://hg.mozilla.org/mozilla-central/rev/2127be51a12e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.