Need to provide sigslot.h from jingle or chromium/ipc for mtransport

RESOLVED FIXED in mozilla18

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 1 bug)

unspecified
mozilla18
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc+], [qa-])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
media/mtransport depends on sigslot.h, currently in media/webrtc/trunk/third_party/libjingle (which is not on m-c).

We need to either subset libjingle down, add sigslot to chromium/ipc, import it separately into webrtc or mtransport, or implement an alternative.

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc+]
(Assignee)

Comment 1

5 years ago
Created attachment 664787 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport
(Assignee)

Comment 2

5 years ago
Created attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

sorry, last had two unintentional inclusions
(Assignee)

Updated

5 years ago
Attachment #664787 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #664790 - Flags: review?(ekr)
(Assignee)

Comment 3

5 years ago
Created attachment 664791 [details] [diff] [review]
License.html tweak for sigslot.h
(Assignee)

Comment 4

5 years ago
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Gerv - dotting i's - I assume you're ok with importing this, and no new license text is required (libjingle is already there).  At most we would want to change the libjingle license.txt entry to specify the new location for this one file (see other attached patch).  We do not intend to import any other part of libjingle at this time.
Attachment #664790 - Flags: review?(gerv)
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Yes, that's fine. Please do an update as you suggest.

Gerv
Attachment #664790 - Flags: review?(gerv) → review+

Comment 6

5 years ago
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Review of attachment 664790 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #664790 - Flags: review?(ekr) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a4e5f65837
(the code landed with the mtransport patch as part of the main webrtc landing)
https://hg.mozilla.org/mozilla-central/rev/d9a4e5f65837
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+], [qa-]
You need to log in before you can comment on or make changes to this bug.