Closed Bug 782873 Opened 8 years ago Closed 7 years ago

Need to provide sigslot.h from jingle or chromium/ipc for mtransport

Categories

(Core :: WebRTC, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Whiteboard: [WebRTC], [blocking-webrtc+], [qa-])

Attachments

(2 files, 1 obsolete file)

media/mtransport depends on sigslot.h, currently in media/webrtc/trunk/third_party/libjingle (which is not on m-c).

We need to either subset libjingle down, add sigslot to chromium/ipc, import it separately into webrtc or mtransport, or implement an alternative.
Whiteboard: [WebRTC], [blocking-webrtc+]
sorry, last had two unintentional inclusions
Attachment #664787 - Attachment is obsolete: true
Attachment #664790 - Flags: review?(ekr)
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Gerv - dotting i's - I assume you're ok with importing this, and no new license text is required (libjingle is already there).  At most we would want to change the libjingle license.txt entry to specify the new location for this one file (see other attached patch).  We do not intend to import any other part of libjingle at this time.
Attachment #664790 - Flags: review?(gerv)
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Yes, that's fine. Please do an update as you suggest.

Gerv
Attachment #664790 - Flags: review?(gerv) → review+
Comment on attachment 664790 [details] [diff] [review]
Import sigslot.h from libjingle to mtransport

Review of attachment 664790 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #664790 - Flags: review?(ekr) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a4e5f65837
(the code landed with the mtransport patch as part of the main webrtc landing)
https://hg.mozilla.org/mozilla-central/rev/d9a4e5f65837
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+], [qa-]
You need to log in before you can comment on or make changes to this bug.