Lower peak memory usage of SafeBrowsing updates

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: gcp, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
As seen in the the analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=673470#c126, there is a peak memory usge of 8.4M in SafeBrowsing updates. If we can lower this peak usage without much problems, we should.

There is an initial patch here: https://bugzilla.mozilla.org/show_bug.cgi?id=673470#c127

Chromium avoids this issue by using std:deque's:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_store.cc?revision=107415&view=markup
(Assignee)

Updated

4 years ago
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
(Reporter)

Comment 1

4 years ago
Much improved by a bunch of other bugs, i.e.:
https://bugzilla.mozilla.org/show_bug.cgi?id=995782
https://bugzilla.mozilla.org/show_bug.cgi?id=970981
https://bugzilla.mozilla.org/show_bug.cgi?id=821992
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.