The default bug view has changed. See this FAQ.

Enum class replacement needs to have default zero-arg constructor

RESOLVED FIXED in mozilla17

Status

()

Core
MFBT
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On compilers that don't support enum class, we define it as a class and define our own constructors.  These override the default constructors, so

  Enum res;

no longer works.  We need a default constructor with zero arguments that does nothing.
Created attachment 652067 [details] [diff] [review]
Patch
Attachment #652067 - Flags: review?(ehsan)
No longer blocks: 779473

Updated

5 years ago
Attachment #652067 - Flags: review?(ehsan) → review+
Green try: https://tbpl.mozilla.org/?tree=Try&rev=8d6b61bf89ac

https://hg.mozilla.org/integration/mozilla-inbound/rev/88b802832f52
Flags: in-testsuite-
Backed out for Android builds failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ec214f806c

https://hg.mozilla.org/integration/mozilla-inbound/rev/22ce0a41fe21
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d2db7e3879a
https://hg.mozilla.org/mozilla-central/rev/7d2db7e3879a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.