Last Comment Bug 782919 - Enum class replacement needs to have default zero-arg constructor
: Enum class replacement needs to have default zero-arg constructor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MFBT (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla17
Assigned To: :Aryeh Gregor (away until August 15)
:
Mentors:
Depends on:
Blocks: 751554
  Show dependency treegraph
 
Reported: 2012-08-15 04:16 PDT by :Aryeh Gregor (away until August 15)
Modified: 2012-08-17 19:23 PDT (History)
1 user (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.96 KB, patch)
2012-08-15 04:17 PDT, :Aryeh Gregor (away until August 15)
ehsan: review+
Details | Diff | Splinter Review

Description :Aryeh Gregor (away until August 15) 2012-08-15 04:16:12 PDT
On compilers that don't support enum class, we define it as a class and define our own constructors.  These override the default constructors, so

  Enum res;

no longer works.  We need a default constructor with zero arguments that does nothing.
Comment 1 :Aryeh Gregor (away until August 15) 2012-08-15 04:17:35 PDT
Created attachment 652067 [details] [diff] [review]
Patch
Comment 4 Ed Morley [:emorley] 2012-08-17 04:32:20 PDT
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d2db7e3879a
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-17 19:23:31 PDT
https://hg.mozilla.org/mozilla-central/rev/7d2db7e3879a

Note You need to log in before you can comment on or make changes to this bug.