782919 - Enum class replacement needs to have default zero-arg constructor

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

On compilers that don't support enum class, we define it as a class and define our own constructors.  These override the default constructors, so

  Enum res;

no longer works.  We need a default constructor with zero arguments that does nothing.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Green try: https://tbpl.mozilla.org/?tree=Try&rev=8d6b61bf89ac

https://hg.mozilla.org/integration/mozilla-inbound/rev/88b802832f52

Comment 3

[Ed Morley [:emorley]]

Backed out for Android builds failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ec214f806c

https://hg.mozilla.org/integration/mozilla-inbound/rev/22ce0a41fe21

Comment 4

[Ed Morley [:emorley]]

Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d2db7e3879a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d2db7e3879a