Closed
Bug 782919
Opened 13 years ago
Closed 13 years ago
Enum class replacement needs to have default zero-arg constructor
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
1.96 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
On compilers that don't support enum class, we define it as a class and define our own constructors. These override the default constructors, so
Enum res;
no longer works. We need a default constructor with zero arguments that does nothing.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #652067 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•13 years ago
|
No longer blocks: nsresult-enum-class
|
||
Updated•13 years ago
|
Attachment #652067 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Green try: https://tbpl.mozilla.org/?tree=Try&rev=8d6b61bf89ac
https://hg.mozilla.org/integration/mozilla-inbound/rev/88b802832f52
Flags: in-testsuite-
|
||
Comment 3•13 years ago
|
||
Backed out for Android builds failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19ec214f806c
https://hg.mozilla.org/integration/mozilla-inbound/rev/22ce0a41fe21
|
|
||
Comment 4•13 years ago
|
||
Sorry, was looking at the wrong push. Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d2db7e3879a
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•