The default bug view has changed. See this FAQ.

IonMonkey: Fix 3d-raytrace regression

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ion:p1])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 652117 [details] [diff] [review]
Patch

This came in with the latest m-c merge. The problem is that if a lookup is uncacheable (in this case a missing property on a dense array), but we don't disable the IC, we were still inlining the shape in Ion.

This patch changes things so that we only inline a monomorphic getprop/setprop in Ion if all lookups were cacheable.
Attachment #652117 - Flags: review?(dvander)
Attachment #652117 - Flags: review?(dvander) → review+
Whiteboard: [ion:p1]
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/53474b3d98aa
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.