This breaks when we start denying access to chrome objects without __exposedProps__. Patch coming up to fix the issue.
Created attachment 652175 [details] [diff] [review]
Expose find results via XPCOM. v1
Attaching a patch. Gregor, if you're unsatisfied with the performance here, can you take
responsibility for fix the API as necessary so that it works with mandatory __exposedProps__?
I want to land this stuff ASAP before more insecure APIs arrive on m-c.
I manually ran the contact tests (since there aren't so many of them) in order to reduce try load. Pushed to m-i:
I just did the performance test:
loading 500 contacts without this patch: 2.1 - 2.6 sec
with this patch: 3.5 - 4 sec :(
I guess we have to fix it with __exposedProps__
I will file a followup
(In reply to Gregor Wagner [:gwagner] from comment #3)
> I just did the performance test:
> loading 500 contacts without this patch: 2.1 - 2.6 sec
> with this patch: 3.5 - 4 sec :(
> I guess we have to fix it with __exposedProps__
> I will file a followup
Is this still the case? We might be able to shave off a few seconds off the loading time for getAll if we can fix this performance regression.