Closed Bug 783057 Opened 8 years ago Closed 8 years ago
Contacts API exposes raw JS objects to content via find
This breaks when we start denying access to chrome objects without __exposedProps__. Patch coming up to fix the issue.
Attaching a patch. Gregor, if you're unsatisfied with the performance here, can you take responsibility for fix the API as necessary so that it works with mandatory __exposedProps__? I want to land this stuff ASAP before more insecure APIs arrive on m-c.
Attachment #652175 - Flags: review?(anygregor)
Attachment #652175 - Flags: review?(anygregor) → review+
Thanks Gregor. I manually ran the contact tests (since there aren't so many of them) in order to reduce try load. Pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d1deb480cfd
I just did the performance test: loading 500 contacts without this patch: 2.1 - 2.6 sec with this patch: 3.5 - 4 sec :( I guess we have to fix it with __exposedProps__ I will file a followup
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(In reply to Gregor Wagner [:gwagner] from comment #3) > I just did the performance test: > loading 500 contacts without this patch: 2.1 - 2.6 sec > with this patch: 3.5 - 4 sec :( > I guess we have to fix it with __exposedProps__ > I will file a followup Is this still the case? We might be able to shave off a few seconds off the loading time for getAll if we can fix this performance regression.
You need to log in before you can comment on or make changes to this bug.