Closed Bug 783086 Opened 8 years ago Closed 8 years ago

[DeviceStorage]: in OOP apps, the enumerate() method ignores the since argument

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: djf, Assigned: dougt)

Details

Attachments

(1 file, 1 obsolete file)

The gallery app just switched to OOP, which triggered a DeviceStorage bug:

My call to enumerate() ignores the since property of the options object.  It returns files with mod times before the specified date.  Blacklisting the app again makes the bug go away.

I'd guess that you're serializing the options object to go cross process but the Date object isn't serializing correctly.

If you want to change the API to take a timestamp instead of a Date object it is probably not too late to do that.  Otherwise, you'll have to manually serialize the date.

I've seen this on desktop and on otoro
Assignee: nobody → doug.turner
Attached patch patch v.1 (obsolete) — Splinter Review
Attachment #652251 - Flags: review?(khuey)
Comment on attachment 652251 [details] [diff] [review]
patch v.1

Wrong patch.
Attachment #652251 - Flags: review?(khuey) → review-
Attached patch patch v.1Splinter Review
Attachment #652251 - Attachment is obsolete: true
Attachment #652587 - Flags: review?(khuey)
Comment on attachment 652587 [details] [diff] [review]
patch v.1

ingore the printf()
Attachment #652587 - Flags: review?(khuey) → review?(dhylands)
Comment on attachment 652587 [details] [diff] [review]
patch v.1

Review of attachment 652587 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (ignoring the printf in nsDeviceStorage.cpp)
Attachment #652587 - Flags: review?(dhylands) → review+
https://hg.mozilla.org/mozilla-central/rev/431d680e9e2f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.