The default bug view has changed. See this FAQ.

[DeviceStorage]: in OOP apps, the enumerate() method ignores the since argument

RESOLVED FIXED in mozilla17

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: djf, Assigned: dougt)

Tracking

Trunk
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The gallery app just switched to OOP, which triggered a DeviceStorage bug:

My call to enumerate() ignores the since property of the options object.  It returns files with mod times before the specified date.  Blacklisting the app again makes the bug go away.

I'd guess that you're serializing the options object to go cross process but the Date object isn't serializing correctly.

If you want to change the API to take a timestamp instead of a Date object it is probably not too late to do that.  Otherwise, you'll have to manually serialize the date.

I've seen this on desktop and on otoro
(Assignee)

Updated

5 years ago
Assignee: nobody → doug.turner
(Assignee)

Comment 1

5 years ago
Created attachment 652251 [details] [diff] [review]
patch v.1
Attachment #652251 - Flags: review?(khuey)
Comment on attachment 652251 [details] [diff] [review]
patch v.1

Wrong patch.
Attachment #652251 - Flags: review?(khuey) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 652587 [details] [diff] [review]
patch v.1
Attachment #652251 - Attachment is obsolete: true
Attachment #652587 - Flags: review?(khuey)
(Assignee)

Comment 4

5 years ago
Comment on attachment 652587 [details] [diff] [review]
patch v.1

ingore the printf()
(Assignee)

Updated

5 years ago
Attachment #652587 - Flags: review?(khuey) → review?(dhylands)
Comment on attachment 652587 [details] [diff] [review]
patch v.1

Review of attachment 652587 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (ignoring the printf in nsDeviceStorage.cpp)
Attachment #652587 - Flags: review?(dhylands) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/431d680e9e2f
https://hg.mozilla.org/mozilla-central/rev/431d680e9e2f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.