783086 - [DeviceStorage]: in OOP apps, the enumerate() method ignores the since argument

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[David Flanagan [:djf]]

The gallery app just switched to OOP, which triggered a DeviceStorage bug:

My call to enumerate() ignores the since property of the options object.  It returns files with mod times before the specified date.  Blacklisting the app again makes the bug go away.

I'd guess that you're serializing the options object to go cross process but the Date object isn't serializing correctly.

If you want to change the API to take a timestamp instead of a Date object it is probably not too late to do that.  Otherwise, you'll have to manually serialize the date.

I've seen this on desktop and on otoro

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 652251 [details] [diff] [review]
patch v.1

Wrong patch.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 652587 [details] [diff] [review]
patch v.1

ingore the printf()

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 652587 [details] [diff] [review]
patch v.1

Review of attachment 652587 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (ignoring the printf in nsDeviceStorage.cpp)

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/431d680e9e2f

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/431d680e9e2f