Last Comment Bug 783150 - B2G RIL: Fetch ICC Record only when SIM_READY
: B2G RIL: Fetch ICC Record only when SIM_READY
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Yoshi Huang[:allstars.chh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-15 19:35 PDT by Yoshi Huang[:allstars.chh]
Modified: 2012-08-16 06:17 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.45 KB, patch)
2012-08-15 19:40 PDT, Yoshi Huang[:allstars.chh]
vicamo: review+
Details | Diff | Splinter Review
Patch. v2 (2.46 KB, patch)
2012-08-15 19:57 PDT, Yoshi Huang[:allstars.chh]
no flags Details | Diff | Splinter Review

Description Yoshi Huang[:allstars.chh] 2012-08-15 19:35:11 PDT
Currently the ICC records will be fetched when radio state is changed.
However, most ICC records(IMSI, MBDN, UST, MSISDN) can be got only when SIM_READY,
in other radio states, i.e. Pin_lock, trying to get these records will fail.
Comment 1 Yoshi Huang[:allstars.chh] 2012-08-15 19:40:21 PDT
Created attachment 652297 [details] [diff] [review]
Patch

Hi, Vicamo
Can you help to review this quick patch for me ?

Thanks
Comment 2 Vicamo Yang [:vicamo][:vyang] 2012-08-15 19:53:38 PDT
Comment on attachment 652297 [details] [diff] [review]
Patch

Review of attachment 652297 [details] [diff] [review]:
-----------------------------------------------------------------

Terrific!
Comment 3 Yoshi Huang[:allstars.chh] 2012-08-15 19:57:52 PDT
Created attachment 652302 [details] [diff] [review]
Patch. v2

Rebase.
Thanks, Vicamo.
Comment 4 Yoshi Huang[:allstars.chh] 2012-08-15 19:59:51 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f50d6dc61e
Comment 5 Ed Morley [:emorley] 2012-08-16 06:17:21 PDT
https://hg.mozilla.org/mozilla-central/rev/e0f50d6dc61e

Note You need to log in before you can comment on or make changes to this bug.