783206 - replace NULL with nullptr in intl except to OS API usages

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 652376 [details] [diff] [review]
fix

Review of attachment 652376 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/locale/src/mac/nsCollationMacUC.cpp
@@ +12,5 @@
>  
>  nsCollationMacUC::nsCollationMacUC() 
>    : mInit(false)
>    , mHasCollator(false)
>    , mLocale(NULL)

why do this and mCollator(NULL) below not get changed?

::: intl/locale/src/nsLocaleService.cpp
@@ +314,5 @@
>    int countLang = 0;
>    char	acceptLanguageList[NSILOCALE_MAX_ACCEPT_LANGUAGE][NSILOCALE_MAX_ACCEPT_LENGTH];
>    nsresult	result;
>  
> +  nsAutoArrayPtr<char> input(new char[strlen(acceptLanguage)+1]);

This change and the similar one in  nsUnicodeDecodeHelper::CreateFastTable below don't really belong in this patch, but they're small enough that I don't think it matters.

Comment 3

[(no longer active)]

Can we land this before somebody works on bug 784739?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Simon Montagu from comment #2)
> Comment on attachment 652376 [details] [diff] [review]
> fix
> 
> Review of attachment 652376 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: intl/locale/src/mac/nsCollationMacUC.cpp
> @@ +12,5 @@
> >  
> >  nsCollationMacUC::nsCollationMacUC() 
> >    : mInit(false)
> >    , mHasCollator(false)
> >    , mLocale(NULL)
> 
> why do this and mCollator(NULL) below not get changed?

This uses OS API handle (LocaleRef and CollatorRef).

Comment 5

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ede84a1a43cf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ede84a1a43cf