The default bug view has changed. See this FAQ.

replace NULL with nullptr in intl except to OS API usages

RESOLVED FIXED in mozilla17

Status

()

Core
Internationalization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 652376 [details] [diff] [review]
fix
(Assignee)

Updated

5 years ago
Attachment #652376 - Flags: review?(smontagu)
(Assignee)

Updated

5 years ago
Summary: replace NULL with nullptr in intl except to API usages → replace NULL with nullptr in intl except to OS API usages
Comment on attachment 652376 [details] [diff] [review]
fix

Review of attachment 652376 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/locale/src/mac/nsCollationMacUC.cpp
@@ +12,5 @@
>  
>  nsCollationMacUC::nsCollationMacUC() 
>    : mInit(false)
>    , mHasCollator(false)
>    , mLocale(NULL)

why do this and mCollator(NULL) below not get changed?

::: intl/locale/src/nsLocaleService.cpp
@@ +314,5 @@
>    int countLang = 0;
>    char	acceptLanguageList[NSILOCALE_MAX_ACCEPT_LANGUAGE][NSILOCALE_MAX_ACCEPT_LENGTH];
>    nsresult	result;
>  
> +  nsAutoArrayPtr<char> input(new char[strlen(acceptLanguage)+1]);

This change and the similar one in  nsUnicodeDecodeHelper::CreateFastTable below don't really belong in this patch, but they're small enough that I don't think it matters.
Attachment #652376 - Flags: review?(smontagu) → review+
Can we land this before somebody works on bug 784739?
Blocks: 784739
(Assignee)

Comment 4

5 years ago
(In reply to Simon Montagu from comment #2)
> Comment on attachment 652376 [details] [diff] [review]
> fix
> 
> Review of attachment 652376 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: intl/locale/src/mac/nsCollationMacUC.cpp
> @@ +12,5 @@
> >  
> >  nsCollationMacUC::nsCollationMacUC() 
> >    : mInit(false)
> >    , mHasCollator(false)
> >    , mLocale(NULL)
> 
> why do this and mCollator(NULL) below not get changed?

This uses OS API handle (LocaleRef and CollatorRef).
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ede84a1a43cf
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/ede84a1a43cf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.