783208 - [Tablet] Double tap zoom-out not working in landscape mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Paul Feher]

Attachment: Log file

Firefox Mobile Native 15.0b5 build1 (2012-08-15)
Device: Samsung Galaxy Tab (Android 3.1)

Steps to reproduce:
1. Go to http://cnn.com in landscape mode.
2. Double tap to zoom-in on a page section without loading any link (Ex: Travel).
3. Double tap to zoom-out the page section.


Expected result:
The page should zoom-in and zoom-out accordingly to the double tap action.

Actual result:
The page remains zoomed-in, the double tap zoom-out action is not working.

NOTE:Please see the attached log file.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The problem here seems to be that the ideal zoom-to-block on those sections would exceed the 4.0 max zoom limit. Instead we just zoom to 4.0 and so the block doesn't take up as much space as we expect it to. As a result the _isRectZoomedIn check returns false, and we try to zoom in again even though we can't because of the limit. Patch coming

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dff40a793fab

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 652435 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Double-tap to zoom out might not work when zoomed in to max zoom
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): mobile only, low risk
String or UUID changes made by this patch: none

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 652435 [details] [diff] [review]
Patch

We're not taking any more changes on mozilla-beta at this stage, will wait for aurora approval until this has baked on central.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dff40a793fab

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/04e23ec85ebb

Comment 8

[Adrian Tamas (:AdrianT)]

Unable to reproduce the issue on:

Firefox Mobile 16.0b5
Samsung Galaxy Tab (Android 3.1)

Marking as verified on Firefox Mobile 16.