783239 - [Tablet] Font color for "Pair a device" option is not visible

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Paul Feher]

Attachment: Device screenshot

Firefox Mobile Native 15.0b5 build1 (2012-08-15)
Device: Samsung Galaxy Tab (Android 3.1)

Steps to reproduce:
1. Set up an initial Data sync.
2. Go to Android Settings > Accounts and tap on Firefox Sync account.
3. Tap on the Firefox Sync account.


Expected result:
The "Pair a device" option should be visible clearly.

Actual result:
The "Pair a device" option is not visible clear because the font color is approximately the same with the background color.

NOTE:Please see the attached screenshot.

Comment 1

[Aaron Train [:aaronmt]]

Might be a fault of TouchWiz; what control do we have here?

Comment 2

[Richard Newman [:rnewman]]

Yeah, this isn't an issue in TouchWiz on phones (S3) or other tablets (TF101), so I'd be inclined to sigh in the general direction of whatever person decided to make that screen white on their version of Android. 

We might be able to make that whole screen black, or there might be a style option for contrasting color. 

liuche's work on options dialog might play in here.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Yeah, this isn't an issue in TouchWiz on phones (S3) or other tablets
> (TF101), so I'd be inclined to sigh in the general direction of whatever
> person decided to make that screen white on their version of Android. 

I'm not sure we play by Android theming best practices here :(  I would sign in the direction of how hard it is to actually play by Android theming best practices.

We're going to need to implement ibarlow's tablet interface mocks sometime soon, anyway (Bug 767179) so I'm going to mark this blocking that.

Comment 4

[Nick Alexander :nalexander [he/him]]

Okay, after some investigation, I have no idea how to change this.  The whole "embedded Account options" thing is a gross hack and theming the embedded PreferenceFragment doesn't seem to be supported at all.  See http://source-android.frandroid.com/packages/apps/Settings/src/com/android/settings/accounts/AccountPreferenceBase.java for the relevant source inflating the PreferenceFragment; I see no way to hook into this and set an appropriate theme.

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #4)
> Okay, after some investigation, I have no idea how to change this.  The
> whole "embedded Account options" thing is a gross hack and theming the
> embedded PreferenceFragment doesn't seem to be supported at all.  See
> http://source-android.frandroid.com/packages/apps/Settings/src/com/android/
> settings/accounts/AccountPreferenceBase.java for the relevant source
> inflating the PreferenceFragment; I see no way to hook into this and set an
> appropriate theme.

Further: http://code.google.com/p/android/issues/detail?id=4611#c26.  This dude is right, Android is hard coding the theme for the relevant prefs, which clashes with the device default theme.  You stay classy, Android.

Comment 6

[Richard Newman [:rnewman]]

Android deserves a CANTFIX resolution. Thanks for trying, Nick. We'll have to bear this in mind when we grow a full settings UI.