783251 - [Tablet] Sync tabs username and device identifiers are cut off if they run over 1 line

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Description

[Paul Feher]

Attachment: Device screenshot

Firefox Mobile Native 15.0b5 build1 (2012-08-15)
Device: Samsung Galaxy Tab (Android 3.1)

Steps to reproduce:
1. Set up an initial Data sync.
2. In the "Synced Tabs" section tap on "Show all tabs".

Expected result:
After tapping on it the tab menu should appear containing the synced tabs and the source indicator.The source indicator text should not be cut off.

Actual result:
The source indicator text is cut off.

NOTE:Please see the attached screenshot.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we get a new design to handle long headers?

Comment 2

[Paul Feher]

This issue is still reproducible on:

Firefox Mobile Native 17.0b5 build1 (2012-11-07)
Device: Acer A500 Tab (Android 3.2.1)

Comment 3

[Aaron Train [:aaronmt]]

This is likely too late to track 17 since it still requires information from August.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

After experimenting a bit, I am limiting the name to be in a single line like on phones. If I allow 2 lines, a small text like "Sriram's Work" is take the same space as two lines. Instead this felt better and would make users have shorter names ;)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I just want some Ian feedback before we move ahead with this change. Phones will actually show more text than the tablet since the width is larger in the tabs tray.

If we make this change, we will likely lose the "machine" name, which seems more important to me.

Comment 6

[Ian Barlow (:ibarlow)]

I am all for saving space, but I think we're better off playing it safe with two line titles here. Unless we can be smart about detecting when a title is longer than one line, which I imagine is unlikely. 

Beyond that, though, I agree with Mark's point about the device information being the most relevant for *most* use cases. Perhaps it would be a good time to revisit the way in which we name synced devices? Is that a thing we do? Do we get that from the Firefox Sync service?

Comment 7

[Sriram Ramasubramanian [:sriram]]

We get the sync name from.. hmm.. sync. This can be edited though (which again is a big usability problem). I can make it two lines. But still it might get cut off.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 687991 [details] [diff] [review]
Patch

r- doesn't seem to be what we want to do

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.