As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 783272 - IonMonkey: Remove code to eagerly spill phis if there's no register available
: IonMonkey: Remove code to eagerly spill phis if there's no register available
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem]
: general
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 777561
  Show dependency treegraph
Reported: 2012-08-16 07:39 PDT by Jan de Mooij [:jandem]
Modified: 2012-08-17 04:05 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (1.23 KB, patch)
2012-08-16 07:39 PDT, Jan de Mooij [:jandem]
dvander: review+
Details | Diff | Splinter Review

Description User image Jan de Mooij [:jandem] 2012-08-16 07:39:39 PDT
Created attachment 652449 [details] [diff] [review]

Bug 675381 added some code to prevent blocked register allocation at phis. This hurts the loop in 3d-cube's DrawLine; the code Ion currently generates for the loop is atrocious. The patch reduces the instruction count for that loop from 43 to 29 and reduces the benchmark time from 12.2 to 11.7 ms.

I will fuzz this for a few hours before landing, just in case I'm missing something, but I'm pretty sure this patch is safe now.
Comment 1 User image Jan de Mooij [:jandem] 2012-08-17 04:05:41 PDT

This didn't turn out to be a large 3d-cube win on AWFY, but it helped ss-nsieve, navier-stokes and gaussian-blur.

Note You need to log in before you can comment on or make changes to this bug.