IonMonkey: Remove code to eagerly spill phis if there's no register available

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 652449 [details] [diff] [review]
Patch

Bug 675381 added some code to prevent blocked register allocation at phis. This hurts the loop in 3d-cube's DrawLine; the code Ion currently generates for the loop is atrocious. The patch reduces the instruction count for that loop from 43 to 29 and reduces the benchmark time from 12.2 to 11.7 ms.

I will fuzz this for a few hours before landing, just in case I'm missing something, but I'm pretty sure this patch is safe now.
Attachment #652449 - Flags: review?(dvander)
Attachment #652449 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/d794f23798f4

This didn't turn out to be a large 3d-cube win on AWFY, but it helped ss-nsieve, navier-stokes and gaussian-blur.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.