783288 - "conformant" is not recognized as a valid word

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[:ehsan akhgari]

See <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary>, except that MDN has deleted that page.  :(

Comment 1

[:ehsan akhgari]

Retrieved the instructions from the google cache and moved them here: <https://wiki.mozilla.org/Adding_a_new_word_to_the_en-US_dictionary>

Comment 2

[Mario Alvarado [:marioalv]]

Hi.
Can I work on this bug?

I've reviewed the code and the instrucctions. I have a question.

Should the word "conformant" be added as is, or should the word "conformant" be added with a suffix?
This is an example of a word with a suffix: waffle/MZGDRS.

What do the letters after the slash mean?

Thanks.

Thanks.

Comment 3

[:ehsan akhgari]

(In reply to comment #2)
> Hi.
> Can I work on this bug?
> 
> I've reviewed the code and the instrucctions. I have a question.
> 
> Should the word "conformant" be added as is, or should the word "conformant" be
> added with a suffix?
> This is an example of a word with a suffix: waffle/MZGDRS.
> 
> What do the letters after the slash mean?

You should use the suffixes which make sense for this word.  The list of suffixes is defined in http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/en-US.aff (look for lines beginning with SFX).  Mostly you should look at the list and see which ones it make sense to have for "conformant".

Comment 4

[Mario Alvarado [:marioalv]]

Attachment: First patch to add the word "conformant" to the en-US dictionary

I'm not really sure if the patch is properly generated, or if I should upload the file upstream-hunspell.diff and leave to the patch only the changes to the file en-US.dic .
Can you please advice?

Thanks.

Comment 5

[:ehsan akhgari]

Comment on attachment 666739 [details]
First patch to add the word "conformant" to the en-US dictionary

Looks good, thanks!

Comment 6

[:ehsan akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db9dc0e94815

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db9dc0e94815