Closed Bug 783288 Opened 7 years ago Closed 7 years ago

"conformant" is not recognized as a valid word

Categories

(Core :: Spelling checker, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ehsan, Assigned: marioalv)

Details

(Whiteboard: [mentor=ehsan])

Attachments

(1 file)

See <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary>, except that MDN has deleted that page.  :(
Retrieved the instructions from the google cache and moved them here: <https://wiki.mozilla.org/Adding_a_new_word_to_the_en-US_dictionary>
Hi.
Can I work on this bug?

I've reviewed the code and the instrucctions. I have a question.

Should the word "conformant" be added as is, or should the word "conformant" be added with a suffix?
This is an example of a word with a suffix: waffle/MZGDRS.

What do the letters after the slash mean?

Thanks.

Thanks.
(In reply to comment #2)
> Hi.
> Can I work on this bug?
> 
> I've reviewed the code and the instrucctions. I have a question.
> 
> Should the word "conformant" be added as is, or should the word "conformant" be
> added with a suffix?
> This is an example of a word with a suffix: waffle/MZGDRS.
> 
> What do the letters after the slash mean?

You should use the suffixes which make sense for this word.  The list of suffixes is defined in http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/locales/en-US/hunspell/en-US.aff (look for lines beginning with SFX).  Mostly you should look at the list and see which ones it make sense to have for "conformant".
I'm not really sure if the patch is properly generated, or if I should upload the file upstream-hunspell.diff and leave to the patch only the changes to the file en-US.dic .
Can you please advice?

Thanks.
Attachment #666739 - Flags: review?
Attachment #666739 - Flags: review? → review?(ehsan)
Comment on attachment 666739 [details]
First patch to add the word "conformant" to the en-US dictionary

Looks good, thanks!
Attachment #666739 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/db9dc0e94815
Assignee: nobody → marioalv.mozilla
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/db9dc0e94815
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.