783351 - nsObjectLoadingContent.cpp:2501:11: warning: unused variable ‘topUri’ [-Wunused-variable]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Daniel Holbert [:dholbert]]

Newish build warning:
{
content/base/src/nsObjectLoadingContent.cpp: In member function ‘bool nsObjectLoadingContent::ShouldPlay(nsObjectLoadingContent::FallbackType&)’:

content/base/src/nsObjectLoadingContent.cpp:2501:11: warning: unused variable ‘topUri’ [-Wunused-variable]
}

This variable was never unused in the changeset that added it (for bug 745030):
  https://hg.mozilla.org/mozilla-central/rev/615a657305b5#l1.1453

Presumably, that line can just be removed.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> This variable was never unused in the changeset that added it

er "never used"

Comment 2

[John Schoenick [:johns]]

Attachment: Remove unused variable

Comment 3

[John Schoenick [:johns]]

Comment on attachment 652592 [details] [diff] [review]
Remove unused variable

https://hg.mozilla.org/integration/mozilla-inbound/rev/57de8dafdf2d

try:
https://tbpl.mozilla.org/?tree=Try&rev=46b32a4de584

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57de8dafdf2d