Last Comment Bug 783351 - nsObjectLoadingContent.cpp:2501:11: warning: unused variable ‘topUri’ [-Wunused-variable]
: nsObjectLoadingContent.cpp:2501:11: warning: unused variable ‘topUri’ [-Wunus...
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: John Schoenick [:johns]
: Benjamin Smedberg [:bsmedberg]
Depends on:
Blocks: buildwarning 745030
  Show dependency treegraph
Reported: 2012-08-16 12:43 PDT by Daniel Holbert [:dholbert]
Modified: 2012-08-17 19:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Remove unused variable (1.17 KB, patch)
2012-08-16 15:30 PDT, John Schoenick [:johns]
jaas: review+
john: checkin+
Details | Diff | Splinter Review

Description User image Daniel Holbert [:dholbert] 2012-08-16 12:43:48 PDT
Newish build warning:
content/base/src/nsObjectLoadingContent.cpp: In member function ‘bool nsObjectLoadingContent::ShouldPlay(nsObjectLoadingContent::FallbackType&)’:

content/base/src/nsObjectLoadingContent.cpp:2501:11: warning: unused variable ‘topUri’ [-Wunused-variable]

This variable was never unused in the changeset that added it (for bug 745030):

Presumably, that line can just be removed.
Comment 1 User image Daniel Holbert [:dholbert] 2012-08-16 12:44:24 PDT
(In reply to Daniel Holbert [:dholbert] from comment #0)
> This variable was never unused in the changeset that added it

er "never used"
Comment 2 User image John Schoenick [:johns] 2012-08-16 15:30:07 PDT
Created attachment 652592 [details] [diff] [review]
Remove unused variable
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-08-17 19:21:50 PDT

Note You need to log in before you can comment on or make changes to this bug.