783391 - NS_ERROR_FILE_IS_DIRECTORY on mochitest-chrome runs

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: reverts change to SimpleTest/setup.js

A change I made to testing/mochitest/tests/SimpleTest/setup.js in bug 770770:

http://hg.mozilla.org/mozilla-central/diff/07b53bdc212a/testing/mochitest/tests/SimpleTest/setup.js

Regressed manual mochitest-chrome runs:

$ make mochitest-chrome TEST_PATH=dom/tests/mochitest/webapps/
...
JavaScript error: chrome://mochikit/content/tests/SimpleTest/MozillaLogger.js, line 90: NS_ERROR_FILE_IS_DIRECTORY: Component returned failure code: 0x8052000d (NS_ERROR_FILE_IS_DIRECTORY) [nsIFileOutputStream.init]

It apparently didn't regress automated runs, though, as my TryServer run didn't exhibit the problem:

https://tbpl.mozilla.org/?tree=Try&rev=5b6a466bf1c2

And it doesn't regress all manual runs.  Fabrice noticed the problem on Linux, and Nick noticed it on Mac.  I see it on Linux, but I don't see it on Mac.  (I'm still waiting for my Windows build to finish.)

I made the change because I noticed (on Windows) that the values in question were arrays with a single string item but were being treated as strings, which happens to work but is a recipe for trouble.

Nevertheless, in my testing today I find that they are strings.  I'm not sure why they were arrays in my earlier testing.  Perhaps I mistook them, or maybe their type changed between when I made the observation and when I landed the patch.

In any case, I think the right thing to do is to simply revert the change.  Here's a patch that does so.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 652582 [details] [diff] [review]
patch v1: reverts change to SimpleTest/setup.js

https://hg.mozilla.org/integration/mozilla-inbound/rev/e316e0cca3dc

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e316e0cca3dc