783407 - cookiejars: get channel or nsILoadContext for NPAPI cookie calls

Status: RESOLVED DUPLICATE of bug 1334509

(Core :: Networking: Cookies, defect, P3)

Description

[Jason Duell]

nsNPAPIPlugin.cpp has calls to Get/SetCookieString w/o passing in an nsIChannel, so we can't get appID/inBrowser.   Fix to pass channel (or add IDL version that takes nsILoadContext if channel not accessible).

We can use GetDocumentFromNPP to get nsIDocument, and hopefully use .GetChannel to get channel to pass.

Not needed until/unless we support NPAPI in child processes, and/or we want to allow plugins to access non-default cookie namespaces.  I.e. not basecamp.

Comment 1

[Jason Duell]

bz: do you know if nsIDocument.GetChannel ought to always return a non-null channel by the time an NPAPI plugin in that document calls _set/getvalueforurl?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't think so.  The exception is an about:blank synthetic document; I believe right now those can end up never getting an mChannel.  We could try to fix that, though.

Comment 3

[Jason Duell]

bz: how about GetLoadContext()?  Will  mDocumentContainer always be valid at this point?  It would be easy to add a new cookie IDL function that takes a LoadContext directly instead of a channel.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I think that there should be a useful document container in all cases in which we're instantiating an NPAPI plugin, yes.

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 6

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 7

[Andrea Marchesini [:baku]]

nsNPAPIPlugin doesn't set cookie anymore. See bug 1334509.