Last Comment Bug 783416 - Stop saving the prototype in WindowStateHolder
: Stop saving the prototype in WindowStateHolder
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: [PTO to Dec5] Bill McCloskey (:billm)
: general
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-16 16:40 PDT by [PTO to Dec5] Bill McCloskey (:billm)
Modified: 2012-08-17 19:22 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.35 KB, patch)
2012-08-16 16:40 PDT, [PTO to Dec5] Bill McCloskey (:billm)
mrbkap: review+
Details | Diff | Splinter Review

Description [PTO to Dec5] Bill McCloskey (:billm) 2012-08-16 16:40:46 PDT
Created attachment 652622 [details] [diff] [review]
patch

Blake says this isn't needed anymore.
Comment 1 Blake Kaplan (:mrbkap) 2012-08-16 18:15:46 PDT
Comment on attachment 652622 [details] [diff] [review]
patch

r=me assuming this is green on try. Also, the commit message is for another bug, so you'll want to fix that before checkin.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-08-17 00:59:33 PDT
Comment on attachment 652622 [details] [diff] [review]
patch

Review of attachment 652622 [details] [diff] [review]:
-----------------------------------------------------------------

Love it!

::: dom/base/nsGlobalWindow.cpp
@@ +10337,2 @@
>    JSContext *cx = mContext->GetNativeContext();
>    JSAutoRequest req(cx);

IS this request still needed?
Comment 3 [PTO to Dec5] Bill McCloskey (:billm) 2012-08-17 10:11:01 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/e84276460994
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-17 19:22:44 PDT
https://hg.mozilla.org/mozilla-central/rev/e84276460994

Note You need to log in before you can comment on or make changes to this bug.