783416 - Stop saving the prototype in WindowStateHolder

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Blake says this isn't needed anymore.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 652622 [details] [diff] [review]
patch

r=me assuming this is green on try. Also, the commit message is for another bug, so you'll want to fix that before checkin.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 652622 [details] [diff] [review]
patch

Review of attachment 652622 [details] [diff] [review]:
-----------------------------------------------------------------

Love it!

::: dom/base/nsGlobalWindow.cpp
@@ +10337,2 @@
>    JSContext *cx = mContext->GetNativeContext();
>    JSAutoRequest req(cx);

IS this request still needed?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e84276460994

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e84276460994