783465 - Add a C++-style doubly linked list class to ds/

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

We have JSCList, but it's kind of old. This is nicer. Unfortunately, we can't remove JSCList entirely because it's used outside the JS engine.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is http://mxr.mozilla.org/mozilla-central/source/mfbt/LinkedList.h not usable here?

And fwiw, the only non-js-engine uses of JSCList are XBL code, which should be able to migrated to the mfbt LinkedList.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Hrm, I didn't know about that. It doesn't allow elements to belong to more than one list, which we do need in one case. But I guess it would be better to adapt it than to make a new one. I'll look into that tomorrow.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

FWIW, IonMonkey branch added http://hg.mozilla.org/projects/ionmonkey/file/f6c3f006b57a/js/src/ion/InlineList.h

Which supports both single linked lists (with a forward iterator) and a doubly-linked list that has forward and reverse iterators. It doesn't support adding to more than one list though. I've been meaning to move it to js/src/ or something.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Unassigning myself from old bugs. Don't worry, not quitting.