783521 - [Tablet] Playing HTML5 videos in fullscreen mode doesn't close the tab menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Firefox Mobile Native 15.0b5 build1 (2012-08-15)
Device: Samsung Galaxy Tab (Android 3.1)

Steps to reproduce:
1. Go to http://people.mozilla.com/~nhirata/html_tp/elephants-dream.webm
2. Open tab menu.
3. Long tap on the video side and tap the full-screen option from the context menu.

Expected result:
The video should be payed in full-screen mode and the tab menu closed.

Actual result:
The tab menu is not closed.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Make code more correct

Apparently correct code is not a requirement for correct behaviour! Whodathunkit.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Fix bug

This hides the tabs sidebar on tablets when going into full-screen mode. The sidebar remains hidden if you exit full-screen mode because it's simpler, but I can add some state variables to track that if you prefer.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 685751 [details] [diff] [review]
(2/2) Fix bug

This is fine for now. We have plans to make the tabs sidebar be transient by default, or pinned. We can update the behavior when that code lands.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/498909bdf43f
https://hg.mozilla.org/integration/mozilla-inbound/rev/8151e40d325e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/498909bdf43f
https://hg.mozilla.org/mozilla-central/rev/8151e40d325e

Comment 6

[Paul Feher]

Verified on:
Nightly 20.0a1 (2012-11-29)
Ausu EEE Transformer TF101 (Android 4.0.3)