blob: protocol wrong Content-Type header

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla18
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
The script in attach to https://bugzilla.mozilla.org/show_bug.cgi?id=782342
reproduces this problem.
The Content-Type is always "application/xml".
(Assignee)

Comment 1

6 years ago
Created attachment 652791 [details] [diff] [review]
Bug 783562 - blob: protocol wrong Content-Type header

A patch. Waiting for green on try.
(Assignee)

Comment 2

6 years ago
Created attachment 652835 [details] [diff] [review]
Bug 783562 - blob: protocol wrong Content-Type header, r=jonas
Attachment #652791 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #652835 - Flags: review?(jonas)
Comment on attachment 652835 [details] [diff] [review]
Bug 783562 - blob: protocol wrong Content-Type header, r=jonas

Review of attachment 652835 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks!

::: modules/libjar/nsJARChannel.cpp
@@ +719,5 @@
>      if (NS_FAILED(rv)) return rv;
>  
>      NS_ADDREF(*stream = mJarInput);
> +
> +    mOpened = true;

Nit: I'd keep this together with setting mPending = true so that they are in sync during any functions called by this function. Same in AsyncOpen.
Attachment #652835 - Flags: review?(jonas) → review+
(Assignee)

Updated

6 years ago
Attachment #652835 - Attachment description: Bug 783562 - blob: protocol wrong Content-Type header → Bug 783562 - blob: protocol wrong Content-Type header, r=jonas
Attachment #652835 - Flags: checkin?
(Assignee)

Comment 4

6 years ago
Created attachment 654656 [details] [diff] [review]
Bug 783562 - blob: protocol wrong Content-Type header, r=sicking

title changed
Attachment #652835 - Attachment is obsolete: true
Attachment #652835 - Flags: checkin?
Attachment #654656 - Flags: checkin?
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Attachment #654656 - Flags: checkin?
Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=3eefa652b5f9

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c0e1448ff3b

Should this have a test or is it already covered by existing ones?
Assignee: nobody → amarchesini
Flags: in-testsuite?
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
This patch is covered by existing mochi tests.
Flags: in-testsuite? → in-testsuite-
Flags: in-testsuite- → in-testsuite+

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/9c0e1448ff3b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

6 years ago
Depends on: 786399

Updated

6 years ago
No longer depends on: 786399
You need to log in before you can comment on or make changes to this bug.