783562 - blob: protocol wrong Content-Type header

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

The script in attach to https://bugzilla.mozilla.org/show_bug.cgi?id=782342
reproduces this problem.
The Content-Type is always "application/xml".

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 783562 - blob: protocol wrong Content-Type header

A patch. Waiting for green on try.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 783562 - blob: protocol wrong Content-Type header, r=jonas

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 652835 [details] [diff] [review]
Bug 783562 - blob: protocol wrong Content-Type header, r=jonas

Review of attachment 652835 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks!

::: modules/libjar/nsJARChannel.cpp
@@ +719,5 @@
>      if (NS_FAILED(rv)) return rv;
>  
>      NS_ADDREF(*stream = mJarInput);
> +
> +    mOpened = true;

Nit: I'd keep this together with setting mPending = true so that they are in sync during any functions called by this function. Same in AsyncOpen.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 783562 - blob: protocol wrong Content-Type header, r=sicking

title changed

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=3eefa652b5f9

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c0e1448ff3b

Should this have a test or is it already covered by existing ones?

Comment 6

[Andrea Marchesini [:baku]]

This patch is covered by existing mochi tests.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9c0e1448ff3b