Closed
Bug 783593
Opened 12 years ago
Closed 12 years ago
Device Storage - Add test to verify that onchange notifications go to the correct device storage object
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
|
4.89 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I was concerned a bit that if you requested change notifications for 'pictures' that you would also see notifications for files in 'videos'.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #652800 -
Flags: review?(khuey)
Comment on attachment 652800 [details] [diff] [review] patch v.1 Review of attachment 652800 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/devicestorage/test/test_watchOther.html @@ +16,5 @@ > +<body> > +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=717103">Mozilla Bug 717103</a> > +<p id="display"></p> > +<div id="content" style="display: none"> > + Whitespace at EOL. @@ +71,5 @@ > +storageOther.addEventListener("change", onChangeFail); > + > +// since addEventListener is async, we have to wait until > +// it's definitely done before we make the file. > +setTimeout(makeFile,100); Er, what? Why is AddEventListener async?
Attachment #652800 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
> Er, what? Why is AddEventListener async?
bad comment - ignore, i'll remove everywhere.|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/16c5acf42436
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/16c5acf42436
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•