Last Comment Bug 783593 - Device Storage - Add test to verify that onchange notifications go to the correct device storage object
: Device Storage - Add test to verify that onchange notifications go to the cor...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Doug Turner (:dougt)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-17 09:53 PDT by Doug Turner (:dougt)
Modified: 2012-08-27 06:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (4.89 KB, patch)
2012-08-17 09:55 PDT, Doug Turner (:dougt)
khuey: review+
Details | Diff | Review

Description Doug Turner (:dougt) 2012-08-17 09:53:01 PDT
I was concerned a bit that if you requested change notifications for 'pictures' that you would also see notifications for files in 'videos'.
Comment 1 Doug Turner (:dougt) 2012-08-17 09:55:19 PDT
Created attachment 652800 [details] [diff] [review]
patch v.1
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-08-21 09:03:23 PDT
Comment on attachment 652800 [details] [diff] [review]
patch v.1

Review of attachment 652800 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/test/test_watchOther.html
@@ +16,5 @@
> +<body>
> +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=717103">Mozilla Bug 717103</a>
> +<p id="display"></p>
> +<div id="content" style="display: none">
> +  

Whitespace at EOL.

@@ +71,5 @@
> +storageOther.addEventListener("change", onChangeFail);
> +
> +// since addEventListener is async, we have to wait until
> +// it's definitely done before we make the file.
> +setTimeout(makeFile,100);

Er, what?  Why is AddEventListener async?
Comment 3 Doug Turner (:dougt) 2012-08-21 09:32:00 PDT
> Er, what?  Why is AddEventListener async?
   bad comment - ignore, i'll remove everywhere.

Note You need to log in before you can comment on or make changes to this bug.