Rename ERROR in TransportLayer::State enum

RESOLVED FIXED

Status

()

Core
WebRTC: Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: jesup)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Windows header files #define ERROR, which make using that as an enum value a pain in the ass. We should rename this value.

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc-]
(Assignee)

Updated

5 years ago
Assignee: nobody → rjesup
(Assignee)

Comment 1

5 years ago
Created attachment 664954 [details] [diff] [review]
Change State enum in TransportLayer to TS_FOO to avoid Windows "ERROR" macro

This applies against the webrtc.org -> alder merge I'm getting ready to commit
(Assignee)

Updated

5 years ago
Attachment #664954 - Flags: review?(ekr)

Comment 2

5 years ago
Comment on attachment 664954 [details] [diff] [review]
Change State enum in TransportLayer to TS_FOO to avoid Windows "ERROR" macro

Review of attachment 664954 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #664954 - Flags: review?(ekr) → review+
(Assignee)

Comment 3

5 years ago
Landed in 8a9fbec09693 on alder on 9/17/2012
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.