783700 - nsColumnSetFrame::BuildDisplayList should use nsFrameList::Enumerator to enumerate children

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

We should be using the (relatively new) nsFrameList::Enumerator class for frame-list-iteration where possible, instead of directly walking a frame list.

nsColumnSetFrame::BuildDisplayList currently walks directly over its child list. Filing this bug on switching it to using nsFrameList::Enumerator.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

FWIW, I just cribbed the Enumerator "for" loop line from here:
 http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableRowGroupFrame.cpp#43

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm curious whether you guys think the intent was that we use nsFrameList::Enumerator this way.  (I originally suggested it to dholbert, but then he pointed out that code like this wasn't converted when nsFrameList::Enumerator was introduced.)

Comment 3

[Mats Palmgren (inactive)]

Yes, I think the intent was to convert frame list loops in this way.
I certainly do it whenever I get the chance.  Please r- me if you
see I don't :-)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 652955 [details] [diff] [review]
fix

r=dbaron

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53951ff066a6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/53951ff066a6