The default bug view has changed. See this FAQ.

nsColumnSetFrame::BuildDisplayList should use nsFrameList::Enumerator to enumerate children

RESOLVED FIXED in mozilla17

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We should be using the (relatively new) nsFrameList::Enumerator class for frame-list-iteration where possible, instead of directly walking a frame list.

nsColumnSetFrame::BuildDisplayList currently walks directly over its child list. Filing this bug on switching it to using nsFrameList::Enumerator.
(Assignee)

Comment 1

5 years ago
Created attachment 652955 [details] [diff] [review]
fix

FWIW, I just cribbed the Enumerator "for" loop line from here:
 http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableRowGroupFrame.cpp#43
Attachment #652955 - Flags: review?(dbaron)
(Assignee)

Updated

5 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
I'm curious whether you guys think the intent was that we use nsFrameList::Enumerator this way.  (I originally suggested it to dholbert, but then he pointed out that code like this wasn't converted when nsFrameList::Enumerator was introduced.)
Yes, I think the intent was to convert frame list loops in this way.
I certainly do it whenever I get the chance.  Please r- me if you
see I don't :-)
Comment on attachment 652955 [details] [diff] [review]
fix

r=dbaron
Attachment #652955 - Flags: review?(dbaron) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/53951ff066a6
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/53951ff066a6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.