If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use moztest to post results to autolog

RESOLVED INCOMPLETE

Status

Testing
Marionette
RESOLVED INCOMPLETE
5 years ago
4 years ago

People

(Reporter: jgriffin, Assigned: mihneadb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Now that moztest supports autolog (bug 782848), we should update Marionette to use moztest to post results to autolog.
(Reporter)

Updated

5 years ago
Depends on: 782848
(Assignee)

Updated

5 years ago
Assignee: nobody → mbalaur
(Assignee)

Comment 1

5 years ago
Created attachment 653461 [details] [diff] [review]
required mods for moztest

Needed to add some more info in moztest to support this fully.
Attachment #653461 - Flags: feedback?(jgriffin)
(Assignee)

Comment 2

5 years ago
Created attachment 653462 [details] [diff] [review]
autolog reporting via moztest in marionette

I kept the hardcoded parts as they were before. I cannot really test this, please help with that.
Attachment #653462 - Flags: feedback?(jgriffin)
(Reporter)

Comment 3

5 years ago
Comment on attachment 653461 [details] [diff] [review]
required mods for moztest

Review of attachment 653461 [details] [diff] [review]:
-----------------------------------------------------------------

::: moztest/moztest/output/autolog.py
@@ +57,5 @@
>              for f in failed:
>                  testgroup.add_test_failure(
>                      test=long_name(f),
>                      text='\n'.join(f.output),
> +                    status=f.result_actual,

I think we should use the calculated result here.
Attachment #653461 - Flags: feedback?(jgriffin) → feedback+
(Reporter)

Comment 4

5 years ago
Comment on attachment 653462 [details] [diff] [review]
autolog reporting via moztest in marionette

Review of attachment 653462 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/runtests.py
@@ +282,2 @@
>  
> +        out.post(*out.make_testgroups(collection))

Looking at this again, is there any reason to have this signature for post()?  Could we have out.post(collection), and let the output class do the right thing?
Attachment #653462 - Flags: feedback?(jgriffin) → feedback+
(Assignee)

Comment 5

5 years ago
Created attachment 656632 [details] [diff] [review]
required mods for moztest

Switched post's signature.
Attachment #653461 - Attachment is obsolete: true
Attachment #656632 - Flags: review?(jgriffin)
(Assignee)

Comment 6

5 years ago
Created attachment 656633 [details] [diff] [review]
autolog reporting via moztest in marionette

Modify according to the new signature of post
Attachment #653462 - Attachment is obsolete: true
Attachment #656633 - Flags: review?(jgriffin)
(Reporter)

Comment 7

5 years ago
Comment on attachment 656632 [details] [diff] [review]
required mods for moztest

Review of attachment 656632 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #656632 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 8

5 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 656632 [details] [diff] [review]
> required mods for moztest
> 
> Review of attachment 656632 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm

Pushed in mozbase.
(Reporter)

Comment 9

5 years ago
Comment on attachment 656633 [details] [diff] [review]
autolog reporting via moztest in marionette

I tested this and it works fine!  I'll land it soon.
Attachment #656633 - Flags: review?(jgriffin) → review+
(Reporter)

Comment 10

5 years ago
So, moztest hasn't been synced to m-c yet, so we'll have to hold off landing this patch until that happens.
(Reporter)

Updated

5 years ago
Depends on: 788842
(Assignee)

Comment 11

5 years ago
Ping on this :)
(Reporter)

Comment 12

5 years ago
I think this can be unbitrotted (if needed) and landed now.
(Reporter)

Comment 13

5 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #12)
> I think this can be unbitrotted (if needed) and landed now.

Indeed that has been bitrotted, not too surprisingly.  Mihnea, do you have time to unbitrot it?
(Assignee)

Comment 14

5 years ago
I remember this was not so easy to test. I haven't been following autolog, so I'm not sure how much needs to be changed.

I can find the time to do it but if you already know a quick way to fix this I think it would be (considerably) faster.
(Reporter)

Comment 15

4 years ago
Oof, this is going to be fun to unbitrot.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INCOMPLETE
We dont care about autolog anymore...
You need to log in before you can comment on or make changes to this bug.