783713 - Use moztest to post results to autolog

Status: RESOLVED INCOMPLETE

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Now that moztest supports autolog (bug 782848), we should update Marionette to use moztest to post results to autolog.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: required mods for moztest

Needed to add some more info in moztest to support this fully.

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: autolog reporting via moztest in marionette

I kept the hardcoded parts as they were before. I cannot really test this, please help with that.

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 653461 [details] [diff] [review]
required mods for moztest

Review of attachment 653461 [details] [diff] [review]:
-----------------------------------------------------------------

::: moztest/moztest/output/autolog.py
@@ +57,5 @@
>              for f in failed:
>                  testgroup.add_test_failure(
>                      test=long_name(f),
>                      text='\n'.join(f.output),
> +                    status=f.result_actual,

I think we should use the calculated result here.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 653462 [details] [diff] [review]
autolog reporting via moztest in marionette

Review of attachment 653462 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/runtests.py
@@ +282,2 @@
>  
> +        out.post(*out.make_testgroups(collection))

Looking at this again, is there any reason to have this signature for post()?  Could we have out.post(collection), and let the output class do the right thing?

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: required mods for moztest

Switched post's signature.

Comment 6

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: autolog reporting via moztest in marionette

Modify according to the new signature of post

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 656632 [details] [diff] [review]
required mods for moztest

Review of attachment 656632 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 8

[Mihnea Dobrescu-Balaur (:mihneadb)]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 656632 [details] [diff] [review]
> required mods for moztest
> 
> Review of attachment 656632 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm

Pushed in mozbase.

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 656633 [details] [diff] [review]
autolog reporting via moztest in marionette

I tested this and it works fine!  I'll land it soon.

Comment 10

[Jonathan Griffin (:jgriffin)]

So, moztest hasn't been synced to m-c yet, so we'll have to hold off landing this patch until that happens.

Comment 11

[Mihnea Dobrescu-Balaur (:mihneadb)]

Ping on this :)

Comment 12

[Jonathan Griffin (:jgriffin)]

I think this can be unbitrotted (if needed) and landed now.

Comment 13

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #12)
> I think this can be unbitrotted (if needed) and landed now.

Indeed that has been bitrotted, not too surprisingly.  Mihnea, do you have time to unbitrot it?

Comment 14

[Mihnea Dobrescu-Balaur (:mihneadb)]

I remember this was not so easy to test. I haven't been following autolog, so I'm not sure how much needs to be changed.

I can find the time to do it but if you already know a quick way to fix this I think it would be (considerably) faster.

Comment 15

[Jonathan Griffin (:jgriffin)]

Oof, this is going to be fun to unbitrot.

Comment 16

[David Burns :automatedtester]

We dont care about autolog anymore...