78373 - no context menus for any personal toolbar items

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Claudius Gayle]

***Overview Description: 
  No context menus fire on any personal toolbar items. This behavior is a fairly recent regression
since they only recently started to work correctly.

***Steps to Reproduce: 
1) Launch a window. Right-click, ctrl-click, or click+hold as appropriate on any toolbar bookmark
or folder.

***Actual Results: 

	nada. The items(even if it's just a single bookmark) do make the 'depressed' movement
as if there were buttons and were 'thunked', that might be a clue, cuz there's no reason for a 
singleton bookmark or even a folder to do that. Only the Home/Bookmark buttons should do
that.

***Expected Results: 

	pretty little context menu

***Build Date & Platform Bug Found: 

	All platfroms with the 2001050104 builds

***Additional Information:

This bug is a significant change in behavior since at least the 04/26 builds, maybe even
more recently. cc pink just in case some of his recent context related changes did this,
and cc hewitt cuz this could just as well be b/c of the newnewnewmodern or whatever we're
calling it :-)

Comment 1

[Blake Ross]

Ben has a fix.

Comment 2

[Jacob Kjome]

I'm think I'm seeing something related to this bug when using context menus to
open up a link in a new window.

This is with build #2001050304 on win2k

To reproduce:
1. Go to http://www.mozilla.org/
2. Right click any link
3. If you get a context menu, click somewhere else and try the same thing again
4. At least after this second time, there will be no context menu

To fix this, right click somewhere else on the page, get the context menu, now
left click anywhere to get rid of the context menu, now go back to any link and
right click.  You should now see a context menu.  Now click somewhere else and
try right clicking again on a link.  Again, no context menu.

Is that the same bug as this or should another bug be filed?

Jake

Comment 3

[Francis Chin]

I can see both behaviours on Win98 2001050304:

1) no context menu for personal toolbar
2) no context menu on a page after one has been called and dismissed already for
that page.

Also after trying to call up a context menu and failing, the next click in the
browser window content area (incl. scrollbar) is lost.

Comment 4

[Francis Chin]

The second behaviour has been reported as bug 78725.

Comment 5

[Fabian Guisset]

Attachment: Fix bug 78373 (two-liner)

Comment 6

[Fabian Guisset]

Patch fixes the missing popupset for the bookmarks bmContext context menu. Two
lines. Taking bug, marking P1, CC'ing reviewers. Please r=/sr=, thanks.

Comment 7

[Håkan Waara]

makes sense. r=hwaara

Comment 8

[Alec Flett]

sr=alecf

Comment 9

[Fabian Guisset]

Fix checked in, marking FIXED.
Thanks for the reviews.

Comment 10

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]