783743 - addon-page should work with "index.html?[stuff]" and "index.html#[stuff]" (and both together)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm trying to make my addon-page page handle multiple tasks from that single page. I want it to open to specific content when I click on a <control> button in my simple-prefs, open to different specific content when I click a different <control> button, and have a general information page for my addon.
(My content script would parse the document's location property and hide/unhide based on the .search or .hash properties.)

But when I try to use tabs.open("index.html?something") or tabs.open("index.html#somethingelse"), the navigation bar is still visible.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/639

Pointer to Github pull-request

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 676926 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/639

Tested locally, and it seems to work for me.
index.html, index.html?something, and index.html#somethingelse hid the browser chrome.

mindex.html, mindex.html?something, mindex.html#somethingelse, index.html.bar, index.html.bar?something, and index.html.bar#somethingelse correctly showed browser chrome.

And all tests pass with this applied! :)

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 676926 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/639

Lets land this! ZER0 please make a followup platfrom bug though!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b6e04cabef9da63c4b59bd6d7302c05a5cf65475
Bug 783743 - addon-page should work with "index.html?[stuff]" and "index.html#[stuff]" (and both together)

- Replaced usage of `inContentWhitelist` with `hideChromeForLocation` to have more flexibility about URLs to hide

https://github.com/mozilla/addon-sdk/commit/da55fc6ab245404e4acc5ac815d19cddb0fb5c0e
Merge pull request #639 from ZER0/addon-page/783743

Bug 783743 - addon-page should work with "index.html?…" & "index.html#…" r=@gozala

Comment 5

[Dave Townsend [:mossop]]

This is probably causing a leak on disable, see bug 829845