Closed Bug 783758 Opened 7 years ago Closed 7 years ago

on the pandaboard robocop fails to close pixelbase handle to pixels.map

Categories

(Testing :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jmaher, Assigned: kats)

Details

Attachments

(1 file)

we open a handle to pixels.map and read/write data to it.  We never close this and on the panda board (ICS) we throw errors all over the adb logcat to remind us about this.
Assignee: nobody → bugmail.mozilla
Attached patch PatchSplinter Review
I haven't pushed this to try because it will only tell me about regressions, not if it fixes the errors on the pandaboard. Better to try it directly on a pandaboard and make sure it works.
Attachment #653807 - Flags: review?(jmaher)
Comment on attachment 653807 [details] [diff] [review]
Patch

Review of attachment 653807 [details] [diff] [review]:
-----------------------------------------------------------------

I know that gbrown had landed a patch today which changed some existing tests from BaseTest -> PixelTest.  We should make sure those tests are included as well.

I tested this on my panda board and it seems to work well.

::: mobile/android/base/tests/PixelTest.java.in
@@ +104,5 @@
> +        try {
> +            checkScrollWithBoxes(painted, 0, 0);
> +        } finally {
> +            painted.close();
> +        }

this isn't doing the 'return painted' anymore?
Attachment #653807 - Flags: review?(jmaher) → review+
Rebased and landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/16975ba38809

(In reply to Joel Maher (:jmaher) from comment #2)
> 
> this isn't doing the 'return painted' anymore?

No, none of the callers were using the returned object. Also the convention now is that any function that returns the PaintedSurface is named xxxAndGetPainted, so that the caller knows it is responsible for cleaning up the PaintedSurface.
https://hg.mozilla.org/mozilla-central/rev/16975ba38809
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.