783822 - [Mac default] adopt editBMPanel to new light coloring

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Attachment: WIP patch

Bug 771284 will change the way arrow panels look (dark --> light). We need to adjust the css for our editBMPanel in order to not make it look broken.

Attaching a WIP patch.

Comment 1

[Stefan [:stefanh]]

Note to self:
* Fix colors (fff --> FFFFFF etc)
* Double-check focus border

Comment 2

[Stefan [:stefanh]]

Attachment: Fixed colors

Comment 3

[Stefan [:stefanh]]

Attachment: Almost there...

panel hack will be removed in final patch...

Comment 4

[Stefan [:stefanh]]

2.14 will need this, since the panel change was made for mozilla 17.

Comment 5

[Stefan [:stefanh]]

Attachment: Final version

Some polish and clean-up, compared to the previous patch.

Comment 6

[Karsten Düsterloh]

Comment on attachment 660885 [details] [diff] [review]
Final version

The light colour scheme is definitely an improvement — I never liked the dark stuff anyway. ;-)

>+#editBMPanel_rows > row > textbox[focused="true"],
>+#editBMPanel_rows > row > hbox > textbox[focused="true"] {
>+  border-color: -moz-mac-focusring !important;
>+  /*box-shadow: 0 0 1px -moz-mac-focusring inset,
>+              0 0 4px 1px -moz-mac-focusring,
>+              0 0 1.5px 1px -moz-mac-focusring; */
>+}

The focus rect around the "name" and "tags" fields does not match the one around all other elements, though, which looks very odd. I assume you just forgot to remove the /* */ above and it wasn't on purpose … ;-)

Plus, I wonder why you made the three buttons at the bottom that oblong? They look different now than almost everywhere else, not like "real" buttons …

Comment 7

[Stefan [:stefanh]]

(In reply to Karsten Düsterloh from comment #6)
> Comment on attachment 660885 [details] [diff] [review]
> Final version
> 
> The light colour scheme is definitely an improvement — I never liked the
> dark stuff anyway. ;-)
> 
> >+#editBMPanel_rows > row > textbox[focused="true"],
> >+#editBMPanel_rows > row > hbox > textbox[focused="true"] {
> >+  border-color: -moz-mac-focusring !important;
> >+  /*box-shadow: 0 0 1px -moz-mac-focusring inset,
> >+              0 0 4px 1px -moz-mac-focusring,
> >+              0 0 1.5px 1px -moz-mac-focusring; */
> >+}
> 
> The focus rect around the "name" and "tags" fields does not match the one
> around all other elements, though, which looks very odd. I assume you just
> forgot to remove the /* */ above and it wasn't on purpose … ;-)
>

Ouch, sorry - I commented that out when testing if the !important was needed (yes, it was), then I must have forgotten it.

> Plus, I wonder why you made the three buttons at the bottom that oblong?
> They look different now than almost everywhere else, not like "real" buttons
> …

The min-width of 79px comes from button.css, I guess you could see them as panel "versions" of the normal buttons. Note that they look exactly the same as the ones in the  Firefox version of the panel. I see your point, but I would rather stay in parity with Firefox here (and hasn't Apple's buttons always looked a bit too wide if you don't have enough text in the label?)

Comment 8

[Stefan [:stefanh]]

Attachment: New version

See my previous comment.

Comment 9

[Karsten Düsterloh]

(In reply to Stefan [:stefanh] from comment #7)
> > Plus, I wonder why you made the three buttons at the bottom that oblong?
> > They look different now than almost everywhere else, not like "real" buttons
> > …
> 
> The min-width of 79px comes from button.css, I guess you could see them as
> panel "versions" of the normal buttons.

I'm not concerned about their length but about their actual _form_. Usually, all(?) our buttons have normal Mac-like form with "half circles" on the left and right, but these don't. 

> Note that they look exactly the same as the ones in the Firefox version 
> of the panel.

Maybe.
I'd bet they didn't care about the form on Mac.

> I see your point

I'm not sure you do. ;-)

Comment 10

[Stefan [:stefanh]]

Attachment: Save dialog on 10.8

Comment 11

[Karsten Düsterloh]

Comment on attachment 667537 [details] [diff] [review]
New version

Ah, well, who am I to blame Apple of inconsistent design …

Comment 12

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/9c30ed8bfa50

Comment 13

[Stefan [:stefanh]]

Comment on attachment 667537 [details] [diff] [review]
New version

[Approval Request Comment]
Regression caused by (bug #): Bug 771284
User impact if declined: Odd-looking editBookmarkPanel (mixture of old/new styles)
Testing completed (on m-c, etc.): Nope
Risk to taking this patch (and alternatives if risky): No risk, only theme changes
String changes made by this patch: None

Comment 14

[Stefan [:stefanh]]

http://hg.mozilla.org/releases/comm-aurora/rev/ee67eb163cf6