783843 - SCTP library doesn't consistently use HAVE_SIN_LEN, and we don't set it in configure

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Patch configure.in and netwerk/sctp for HAVE_SIN_LEN

Some code in the SCTP library uses HAVE_SIN_LEN (and it's in the configure.in for the library), but most code doesn't (and uses slightly varying OS selections to control reference to sin_len).

Add HAVE_SIN_LEN to our configure.in, and modify our code and the SCTP library to use it consistently.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 653127 [details] [diff] [review]
Patch configure.in and netwerk/sctp for HAVE_SIN_LEN

Review of attachment 653127 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to be missing the changes to configure.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: configure.in changes

The configure changes got attached to the wrong bug in the queue...

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 653127 [details] [diff] [review]
Patch configure.in and netwerk/sctp for HAVE_SIN_LEN

remarking now that the configure changes are here too
This is the part that gets promoted to the usrsctp team for upstreaming

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 656559 [details] [diff] [review]
configure.in changes

Review of attachment 656559 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2956,5 @@
>  
> +dnl Check for sin_len - used by SCTP; only appears in Mac/*BSD generally
> +MOZ_CHECK_HEADERS(sys/types.h)
> +AC_MSG_CHECKING(for sockaddr_in.sin_len)
> +AC_CACHE_VAL(ac_cv_sockaddr_in_sin_len,

You probably want to use AC_CACHE_CHECK here.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Clean up HAVE_SIN_LEN/HAVE_SIN6_LEN checks

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 658107 [details] [diff] [review]
Clean up HAVE_SIN_LEN/HAVE_SIN6_LEN checks

This should be much cleaner.  Different enough to need a quick re-review though.