SCTP library doesn't consistently use HAVE_SIN_LEN, and we don't set it in configure

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments)

Some code in the SCTP library uses HAVE_SIN_LEN (and it's in the configure.in for the library), but most code doesn't (and uses slightly varying OS selections to control reference to sin_len).

Add HAVE_SIN_LEN to our configure.in, and modify our code and the SCTP library to use it consistently.
Attachment #653127 - Flags: review?(ted.mielczarek)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 653127 [details] [diff] [review]
Patch configure.in and netwerk/sctp for HAVE_SIN_LEN

Review of attachment 653127 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to be missing the changes to configure.
Attachment #653127 - Flags: review?(ted.mielczarek) → review-
The configure changes got attached to the wrong bug in the queue...
Attachment #656559 - Flags: review?(ted.mielczarek)
Comment on attachment 653127 [details] [diff] [review]
Patch configure.in and netwerk/sctp for HAVE_SIN_LEN

remarking now that the configure changes are here too
This is the part that gets promoted to the usrsctp team for upstreaming
Attachment #653127 - Flags: review- → review?(ted.mielczarek)
Comment on attachment 656559 [details] [diff] [review]
configure.in changes

Review of attachment 656559 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2956,5 @@
>  
> +dnl Check for sin_len - used by SCTP; only appears in Mac/*BSD generally
> +MOZ_CHECK_HEADERS(sys/types.h)
> +AC_MSG_CHECKING(for sockaddr_in.sin_len)
> +AC_CACHE_VAL(ac_cv_sockaddr_in_sin_len,

You probably want to use AC_CACHE_CHECK here.
Attachment #656559 - Flags: review?(ted.mielczarek) → review+
Attachment #653127 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 658107 [details] [diff] [review]
Clean up HAVE_SIN_LEN/HAVE_SIN6_LEN checks

This should be much cleaner.  Different enough to need a quick re-review though.
Attachment #658107 - Flags: review?(ted.mielczarek)
Attachment #658107 - Flags: review?(ted.mielczarek) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.