Closed Bug 783953 Opened 8 years ago Closed 8 years ago

Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16.

Categories

(Core :: Audio/Video, defect)

16 Branch
Other
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file, 1 obsolete file)

From bug 775319:

> Can you please file a followup to untangle S16LE vs S16(NE)?  We should rename
> S16LE to just S16 (i.e. native) and do the endian conversion in
> nsWaveReader.cpp; I think everywhere else that uses S16LE is acting as if it's
> NE.

This bug is about removing all the endianess-specific code in content/media but at the source, in nsWaveReader.cpp.

Then we can rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16.
This removes all the endian specific code from content/media.

We extract the bytes from the media files or the network (in case of webrtc) to
native order, so if cubeb is able to use native order, we don't have anything to
do.

I also removed the endian specific code from AudioSegment.cpp, since we can't get
non-native ordered data anyway, no need to convert. Or maybe I miss a use case.
Attachment #655655 - Flags: review?(kinetik)
Comment on attachment 655655 [details] [diff] [review]
Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16. r=

Nice.  I've added f? roc to double check the AudioSegment question.
Attachment #655655 - Flags: review?(kinetik)
Attachment #655655 - Flags: review+
Attachment #655655 - Flags: feedback?(roc)
Comment on attachment 655655 [details] [diff] [review]
Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16. r=

Review of attachment 655655 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.
Attachment #655655 - Flags: feedback?(roc) → feedback+
Attachment #655655 - Attachment is obsolete: true
Attachment #656962 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/978761f9b84e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.