783953 - Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

From bug 775319:

> Can you please file a followup to untangle S16LE vs S16(NE)?  We should rename
> S16LE to just S16 (i.e. native) and do the endian conversion in
> nsWaveReader.cpp; I think everywhere else that uses S16LE is acting as if it's
> NE.

This bug is about removing all the endianess-specific code in content/media but at the source, in nsWaveReader.cpp.

Then we can rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16. r=

This removes all the endian specific code from content/media.

We extract the bytes from the media files or the network (in case of webrtc) to
native order, so if cubeb is able to use native order, we don't have anything to
do.

I also removed the endian specific code from AudioSegment.cpp, since we can't get
non-native ordered data anyway, no need to convert. Or maybe I miss a use case.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 655655 [details] [diff] [review]
Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16. r=

Nice.  I've added f? roc to double check the AudioSegment question.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 655655 [details] [diff] [review]
Rename MOZ_SAMPLE_TYPE_S16LE to MOZ_SAMPLE_TYPE_S16. r=

Review of attachment 655655 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Updated commit message.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(Remarkably) Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=cf7f719d7f47

https://hg.mozilla.org/integration/mozilla-inbound/rev/978761f9b84e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/978761f9b84e