783954 - Move mozglue utility code into org.mozilla.gecko.mozglue package

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-1-mozglue-putenv.patch

Part 1: Move putenv() from GeckoAppShell to mozglue.Environment.

This patch series moves mozglue/android's native methods from GeckoAppShell to a new utility package called `mozglue` that has no other package dependencies.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: part-2-NSSBridge-static-functions.patch

Part 2: Make some NSSBridge.cpp functions static.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: part-3-NSSBridge-duplicated-code.patch

Part 3: Consolidate duplicated NSSBridge code.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: part-4-mozglue-LibraryLoader.patch

Part 4: Move mozglue library loading from GeckoAppShell to mozglue.LibraryLoader.

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: part-5-mozglue-NSSBridge.patch

Part 5: Move NSSBridge to mozglue package.

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: part-6-extract-util-Base64.patch

Part 6: Move Base64 methods from GeckoAppShell to util/Base64Coder.

This patch is admittedly not part of the mozglue package, but like the other patches, it extracts some utility methods from GeckoAppShell (to a new util.Base64coder class). I don't know why callers of Base64coder don't just use android.os.Base64, but this patch series is just untangling dependencies without writing lots of new code.

Comment 7

[Chris Peterson [:cpeterson]]

These patches caused some Robocop failures that I need to fix.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.