Closed Bug 783971 Opened 12 years ago Closed 12 years ago

[gcli] GCLI popup not appearing at its correct position


(DevTools :: General, defect)

Windows 7
Not set


(firefox16 fixed, firefox17 fixed)

Firefox 18
Tracking Status
firefox16 --- fixed
firefox17 --- fixed


(Reporter: Optimizer, Assigned: miker)



(Whiteboard: [gclicommands][fixed-in-fx-team])


(2 files, 1 obsolete file)

Attached image One example
1. type any command 
2. while typing its options, the popup sometimes appear at wrong position. It also overlaps the input area sometimes.

This happens for all boolean options, for options of commands that are not valid and for some other cases that I am unable to pin point.

try these commands :
a. restart t
b. screenshot abc g
c. asdas era
d. screenshot abc 10
I am unable to reproduce this on Linux. Is there anybody that can try this on Windows?
Whiteboard: [gclicommands]
I can reproduce this on Windows & OSX but not on Linux.
Assignee: nobody → mratcliffe
Attached patch Fix (obsolete) — Splinter Review
There is a tooltip bug on Windows and Linux that prevents them from being positioned properly. There is a panel bug on Linux that causes ugly focus issues. We now use a tooltip on Linux and a panel on OSX & Windows. I know it is ugly but the key point is that it works.

If a panel has no content and no height it is not shown when openPopup is called on Windows and OSX ... this was stopping the panel from appearing the first time it was shown (bug 692348). Setting the panel's height to 1px before calling openPopup fixes the issue as we resize it ourselves anyway.
Attachment #656424 - Flags: review?(jwalker)
Comment on attachment 656424 [details] [diff] [review]

Review of attachment 656424 [details] [diff] [review]:

Looks good. Please could you add a slab of docs to the function that lets people unravel what is going on? Particularly useful would be links to bugs etc. Imagine you have a bad memory and have to look at this code in a years time...
Attachment #656424 - Flags: review?(jwalker) → review+
Added comments as requested
Attachment #656424 - Attachment is obsolete: true
Whiteboard: [gclicommands] → [gclicommands][land-in-fx-team]
Whiteboard: [gclicommands][land-in-fx-team] → [gclicommands][fixed-in-fx-team]
Closed: 12 years ago
Resolution: --- → FIXED
We should also get this into Aurora & Beta if possible.
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8)
> We should also get this into Aurora & Beta if possible.

Care to request approval?
Comment on attachment 656794 [details] [diff] [review]
Added extra comments

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Linux Window manager bugs plus Windows and OSX tooltip bugs.
User impact if declined: Panels will be opened in the wrong location ... very ugly.
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None
Attachment #656794 - Flags: approval-mozilla-beta?
Attachment #656794 - Flags: approval-mozilla-aurora?
Comment on attachment 656794 [details] [diff] [review]
Added extra comments

[Triage Comment]
If this is truly a no-risk patch, let's land on branches. If you'd like to reconsider that evaluation, we'd want to know more info about when this originally regressed before landing.
Attachment #656794 - Flags: approval-mozilla-beta?
Attachment #656794 - Flags: approval-mozilla-beta+
Attachment #656794 - Flags: approval-mozilla-aurora?
Attachment #656794 - Flags: approval-mozilla-aurora+
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.