783971 - [gcli] GCLI popup not appearing at its correct position

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Girish Sharma [:Optimizer]]

Attachment: One example

1. type any command 
2. while typing its options, the popup sometimes appear at wrong position. It also overlaps the input area sometimes.

This happens for all boolean options, for options of commands that are not valid and for some other cases that I am unable to pin point.

try these commands :
a. restart t
b. screenshot abc g
c. asdas era
d. screenshot abc 10

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I am unable to reproduce this on Linux. Is there anybody that can try this on Windows?

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can reproduce this on Windows & OSX but not on Linux.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fix

There is a tooltip bug on Windows and Linux that prevents them from being positioned properly. There is a panel bug on Linux that causes ugly focus issues. We now use a tooltip on Linux and a panel on OSX & Windows. I know it is ugly but the key point is that it works.

If a panel has no content and no height it is not shown when openPopup is called on Windows and OSX ... this was stopping the panel from appearing the first time it was shown (bug 692348). Setting the panel's height to 1px before calling openPopup fixes the issue as we resize it ourselves anyway.

Comment 4

[Joe Walker [:jwalker]]

Comment on attachment 656424 [details] [diff] [review]
Fix

Review of attachment 656424 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Please could you add a slab of docs to the function that lets people unravel what is going on? Particularly useful would be links to bugs etc. Imagine you have a bad memory and have to look at this code in a years time...

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Added extra comments

Added comments as requested

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/765c575daef9

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/765c575daef9

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We should also get this into Aurora & Beta if possible.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8)
> We should also get this into Aurora & Beta if possible.

Care to request approval?

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

From who?

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 656794 [details] [diff] [review]
Added extra comments

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Linux Window manager bugs plus Windows and OSX tooltip bugs.
User impact if declined: Panels will be opened in the wrong location ... very ugly.
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 656794 [details] [diff] [review]
Added extra comments

[Triage Comment]
If this is truly a no-risk patch, let's land on branches. If you'd like to reconsider that evaluation, we'd want to know more info about when this originally regressed before landing.

Comment 13

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c14915756148

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7ba553cf616d