Closed Bug 783976 Opened 7 years ago Closed 7 years ago
Fi list can't displayed after enabling/disabling Wi Fi repeatedly
It's similar to bug 774876, but it looks different. For this case, it happened sometimes. Sometimes, it has no problem. Reproducing steps: 1. Enable WiFi. 2. Wait and check the list. 3. Disable WiFi. 4. Repeats step 1-3. Sometimes, in step 2, the list is empty and it just kept searching.
Assignee: nobody → vchang
blocking-basecamp: --- → +
1. Update WifiManager.state before notifying wifiUp event to DOM. 2. Instead of using WifiManager.state to check wifi enable/disable status, we should use WifiManager.enabled in getNetworks, associate and forget functions. 3. The scan function in gaia/apps/settings/js/wifi.js may return if scanning flag is true. We may set it to false before calling scan function in gWifiManager.onenabled .
Attachment #653707 - Flags: feedback?(mrbkap)
Attachment #653707 - Attachment is patch: true
Comment on attachment 653707 [details] [diff] [review] WIP Review of attachment 653707 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/wifi/WifiWorker.js @@ +897,5 @@ > parseStatus(status, reconnected); > callback(); > }); > + > + notify("supplicantconnection"); This change is wrong. statusCommand is async (as are basically all of the calls in this file, though as I say that, I note that parseStatus isn't). The notification should go directly above |callback()|.
Attachment #653707 - Flags: feedback?(mrbkap) → feedback-
Comment on attachment 654170 [details] [diff] [review] Update wifi list can't displayed after enabling/disabling WiFi Looks good. Thanks.
Vincent, Your patch doesn't apply cleanly on inbound anymore. Can you update it, and set the correct hg headers and commit message (using qref -eU)?
No need, I guess :P
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Fabrice Desré [:fabrice] from comment #6) > Vincent, > > Your patch doesn't apply cleanly on inbound anymore. Can you update it, and > set the correct hg headers and commit message (using qref -eU)? Thanks for your reminding. I will take care of it on next time.
(In reply to Ryan VanderMeulen from comment #8) > No need, I guess :P Thanks for your help.
You need to log in before you can comment on or make changes to this bug.