783976 - WiFi list can't displayed after enabling/disabling WiFi repeatedly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Chih Hu [:khu]]

It's similar to bug 774876, but it looks different. For this case, it happened sometimes. Sometimes, it has no problem. 

Reproducing steps:
1. Enable WiFi.
2. Wait and check the list. 
3. Disable WiFi. 
4. Repeats step 1-3. 

Sometimes, in step 2, the list is empty and it just kept searching.

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: WIP

1. Update WifiManager.state before notifying wifiUp event to DOM. 
2. Instead of using WifiManager.state to check wifi enable/disable status, we should use WifiManager.enabled in getNetworks, associate and forget functions. 
3. The scan function in gaia/apps/settings/js/wifi.js may return if scanning flag is true. We may set it to false before calling scan function in gWifiManager.onenabled .

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 653707 [details] [diff] [review]
WIP

Review of attachment 653707 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +897,5 @@
>        parseStatus(status, reconnected);
>        callback();
>      });
> +
> +    notify("supplicantconnection");

This change is wrong. statusCommand is async (as are basically all of the calls in this file, though as I say that, I note that parseStatus isn't). The notification should go directly above |callback()|.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: Update wifi list can't displayed after enabling/disabling WiFi

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Attachment: Update wifi list can't displayed after enabling/disabling WiFi

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 654170 [details] [diff] [review]
Update wifi list can't displayed after enabling/disabling WiFi

Looks good. Thanks.

Comment 6

[[:fabrice] Fabrice Desré]

Vincent,

Your patch doesn't apply cleanly on inbound anymore. Can you update it, and set the correct hg headers and commit message (using qref -eU)?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe06529df135

Comment 8

[Ryan VanderMeulen [:RyanVM]]

No need, I guess :P

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/fe06529df135

Comment 10

[Vincent Chang[:vchang][changyihsin]]

(In reply to Fabrice Desré [:fabrice] from comment #6)
> Vincent,
> 
> Your patch doesn't apply cleanly on inbound anymore. Can you update it, and
> set the correct hg headers and commit message (using qref -eU)?

Thanks for your reminding. I will take care of it on next time.

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Ryan VanderMeulen from comment #8)
> No need, I guess :P

Thanks for your help.