Closed Bug 784039 Opened 12 years ago Closed 9 years ago

Metro firefox Autocomplete results should open in a new tab when ctrl or shift is pressed

Categories

(Firefox for Metro Graveyard :: Browser, defect)

Product:
Firefox for Metro Graveyard
Component:
Browser
Platform:
All
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: bbondy, Unassigned)

References

Details

(Keywords: access, platform-parity, Whiteboard: [defect] p=0) 

Metro firefox Autocomplete results should open in a new tab when ctrl or shift is pressed.  Currently the modifier keys are ignored.
Assignee: netzen → nobody
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
Whiteboard: [metro-mvp?]
nice to have keyboard shortcut but I wouldn't hold v1 for this.
Whiteboard: [metro-mvp?] → [metro-mvp-]
If anyone wants to volunteer to fix this, I think you can check the shiftKey and ctrlKey properties of the aEvent parameter here, and call "this.addTab" instead of "this.goToURI" as needed:

http://hg.mozilla.org/mozilla-central/file/cc37417e2c28/browser/metro/base/content/browser-ui.js#l301
Component: General → Browser
Keywords: access, pp
Hardware: x86_64 → All
Whiteboard: [metro-mvp-] → [metro-mvp-][mentor=mbrubeck][lang=js]
Blocks: metrov2planning
Whiteboard: [metro-mvp-][mentor=mbrubeck][lang=js]
Assignee: nobody → rsilveira
Removed myself from assignee since I'm not working on this and it's v2.
Assignee: rsilveira → nobody
Priority: -- → P4
No longer blocks: metrov2planning
Whiteboard: [defect]
Whiteboard: [defect] → [defect] p=0
Priority: P4 → --
I'll do this. Already through with opening the autocomplete history in new tab. Do we want to switch to the new tab or should we let it load in the background?
OS: Windows 8 Metro → Windows 8.1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.